From: "Benjamin R. Haskell" <zsh@benizi.com>
To: Zsh Workers <zsh-workers@zsh.org>
Subject: Re: #compdef lines prevent X11 and init.d completion
Date: Sun, 10 Jan 2010 13:12:33 -0500 (EST) [thread overview]
Message-ID: <alpine.LNX.2.01.1001101303150.8115@hp.internal> (raw)
In-Reply-To: <alpine.LNX.2.01.1001101051310.8115@hp.internal>
[-- Attachment #1: Type: TEXT/PLAIN, Size: 679 bytes --]
On Sun, 10 Jan 2010, Benjamin R. Haskell wrote:
> [...]
>
> I frequently use <filename as a command unto itself, happily
> tab-completing the whole of filename. But, that line prevents me from
> tab-completing into the /etc/X11 and /usr/share/X11 directories.
>
> [...]
>
> Seems like a bug to me -- not 100% sure where, so I figured I'd ping the
> list before patching it myself.
>
Making _redirect consider whether $CURRENT is 1 seems to solve the
problem for me. Might also make sense to test whether NULLCMD is set.
Not sure if this would have other adverse effects, nor what the mention
of 'ksharrays' in the man page might entail.
Patch attached.
Best,
Ben
[-- Attachment #2: Type: TEXT/PLAIN, Size: 981 bytes --]
Index: Completion/Zsh/Context/_redirect
===================================================================
RCS file: /cvsroot/zsh/zsh/Completion/Zsh/Context/_redirect,v
retrieving revision 1.3
diff -u -r1.3 _redirect
--- Completion/Zsh/Context/_redirect 13 Mar 2002 09:28:05 -0000 1.3
+++ Completion/Zsh/Context/_redirect 10 Jan 2010 18:08:50 -0000
@@ -6,11 +6,13 @@
strs=( -default- )
-if [[ -n "$_comp_command1" ]]; then
- strs=( "${_comp_command1}" "$strs[@]" )
- [[ -n "$_comp_command2" ]] &&
+if [[ "$CURRENT" != "1" ]]; then
+ strs=( "${_comp_command}" "$strs[@]" )
+ if [[ -n "$_comp_command1" ]]; then
+ strs=( "${_comp_command1}" "$strs[@]" )
+ [[ -n "$_comp_command2" ]] &&
strs=( "${_comp_command2}" "$strs[@]" )
+ fi
fi
-_dispatch -redirect-,${compstate[redirect]},${_comp_command} \
- -redirect-,{${compstate[redirect]},-default-},${^strs}
+_dispatch -redirect-,{${compstate[redirect]},-default-},${^strs}
next prev parent reply other threads:[~2010-01-11 7:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-10 17:10 Benjamin R. Haskell
2010-01-10 18:12 ` Benjamin R. Haskell [this message]
2010-01-13 20:28 ` Peter Stephenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.01.1001101303150.8115@hp.internal \
--to=zsh@benizi.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).