From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-28204-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 9189 invoked by alias); 26 Aug 2010 03:30:28 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 28204
Received: (qmail 20637 invoked from network); 26 Aug 2010 03:30:25 -0000
X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham
	version=3.3.1
Received-SPF: pass (ns1.primenet.com.au: SPF record at benizi.com designates 64.130.10.15 as permitted sender)
Date: Wed, 25 Aug 2010 23:29:55 -0400 (EDT)
From: "Benjamin R. Haskell" <zsh@benizi.com>
To: Nikolai Weibull <now@bitwi.se>
cc: Aaron Schrab <aaron@schrab.com>, zsh-workers@zsh.org
Subject: Re: [PATCH] _git: Add completion for help subcommand
In-Reply-To: <AANLkTimOcmpFpTrrVMsuvjCR8puCnhoRVsmduci=SP8d@mail.gmail.com>
Message-ID: <alpine.LNX.2.01.1008252311460.4535@hp>
References: <1282393263-16767-1-git-send-email-aaron@schrab.com> <AANLkTimOcmpFpTrrVMsuvjCR8puCnhoRVsmduci=SP8d@mail.gmail.com>
User-Agent: Alpine 2.01 (LNX 1266 2009-07-14)
MIME-Version: 1.0
Content-Type: MULTIPART/MIXED; BOUNDARY="-1463810530-1609422429-1282793398=:4535"
Content-ID: <alpine.LNX.2.01.1008252329430.4535@hp>

---1463810530-1609422429-1282793398=:4535
Content-Type: TEXT/PLAIN; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Content-ID: <alpine.LNX.2.01.1008252329431.4535@hp>

On Thu, 26 Aug 2010, Nikolai Weibull wrote:

> On Sat, Aug 21, 2010 at 14:21, Aaron Schrab wrote:
> 
> Seems fine except for this:
> 
> > +  local formats='(--info -i --man -m --web -w)'
> 
> Although this is sort of nice it doesn’t follow the style of this or 
> other completion files, so please write out the whole list in each 
> line.

Doesn't seem very common, but a quick grep[1] of Completion/Unix/Command 
shows at least the following use that style to an extent:

_bogoutil
_cvs
_global
_iconv
_whois
_wiggle

It always kind of bothered me that more didn't.

e.g. the lines in _git starting:

'(--name-only --name-status -u -p --stat --patch-with-stat [...]
'(--name-only --name-status -u -p --stat --patch-with-stat [...]
'(--name-only --name-status -u -p --stat --patch-with-stat [...]
'(--name-only --name-status -u -p --stat --patch-with-stat [...]
'(--name-only --name-status -u -p --stat --patch-with-stat [...]

It's just visual clutter.  Is there a particular reason not to use a 
variable?

-- 
Best,
Ben

[1] many false positives, but:
grep $'^\\s*["\'].*\\$' Completion/Unix/Command/*
---1463810530-1609422429-1282793398=:4535--