zsh-workers
 help / color / mirror / code / Atom feed
From: "Benjamin R. Haskell" <zsh@benizi.com>
To: "Alexey I. Froloff" <raorn@altlinux.org>
Cc: zsh-workers@zsh.org
Subject: Re: [PATCH] Completion/Unix/Commands/_ri: updated for Ruby 1.9.2
Date: Wed, 5 Jan 2011 16:27:35 -0500 (EST)	[thread overview]
Message-ID: <alpine.LNX.2.01.1101051618090.2792@hp> (raw)
In-Reply-To: <20110104113222.GA7499@altlinux.org>

On Tue, 4 Jan 2011, Alexey I. Froloff wrote:

> On Fri, Dec 31, 2010 at 01:41:22AM +0300, Alexey I. Froloff wrote:
>> In Ruby 1.9.2 extension of compiled RI files changed from .yaml to 
>> .ri, choose extension accorting to RI version.
> Comments, anyone?

(Apologies in advance if this isn't useful feedback, I'm a Ruby noob.)

Maybe it makes sense, but it seems weird that the tests are conditioned 
on running Ruby scripts rather than looking at `ri --version`.

And how does this fare against different Ruby implementations?  Would 
JRuby 1.9.2 necessarily use the same 'ri' conventions as MRI Ruby 1.9.2?

And more generally, since it's looking in directories that would only 
contain Ruby documentation, would it hurt to include both .yaml and .ri 
for versions that support .ri?

-- 
Best,
Ben


  reply	other threads:[~2011-01-05 21:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-30 22:41 Alexey I. Froloff
2011-01-04 11:32 ` Alexey I. Froloff
2011-01-05 21:27   ` Benjamin R. Haskell [this message]
2011-01-06  0:30     ` Alexey I. Froloff
2011-01-06  6:07       ` Benjamin R. Haskell
2011-01-06  6:01 ` [PATCH] Completion/Unix/Commands/_ri: missed format change Benjamin R. Haskell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LNX.2.01.1101051618090.2792@hp \
    --to=zsh@benizi.com \
    --cc=raorn@altlinux.org \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).