zsh-workers
 help / color / mirror / code / Atom feed
From: "Benjamin R. Haskell" <zsh@benizi.com>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: Mikael Magnusson <mikachu@gmail.com>,
	 Frank Terbeck <ft@bewatermyfriend.org>,
	zsh-workers@zsh.org,  Nikolai Weibull <now@bitwi.se>
Subject: Re: Slowness issue with git completion
Date: Tue, 26 Apr 2011 18:35:24 -0400 (EDT)	[thread overview]
Message-ID: <alpine.LNX.2.01.1104261822400.28316@hp> (raw)
In-Reply-To: <BANLkTi=yAFZJzV+kMWtRRhdn7cnqVuvGng@mail.gmail.com>

[-- Attachment #1: Type: TEXT/PLAIN, Size: 1345 bytes --]

On Wed, 27 Apr 2011, Felipe Contreras wrote:

> On Wed, Apr 27, 2011 at 12:52 AM, Benjamin R. Haskell wrote:
>> It's a workaround.  At some point, someone (probably someone 
>> participating in this thread) will figure out a proper solution.  But 
>> until that happens the workaround is better than breaking the context 
>> sensitivity of git completion just to make it as fast as bash.
>
> I disagree. The "context sensitivity" doesn't work. The current 
> behavior is broken.

Everyone else in the thread seems to think that it's desired.  That is: 
if it weren't unusably slow, it'd be preferable.


> I say it should be the other way around, that "context sensitivity" 
> which is only used for 'git add' should not make the rest of the 
> commands dead slow, it should be disabled until it's working properly 
> (fast).

Disabling the context sensitivity of Zsh's git file completion requires 
rewriting other portions of the completion, since the rest depends on 
being able to call it how it does.  People who are actively contributing 
to the _git function want this functionality.  So, from that perspective 
it's not worth the effort to rip it out.

I've given you an admittedly-stupid workaround.  The other options are 
to wait for someone to fix it, fix it yourself, or use bash (which has 
the behavior you want).

-- 
Best,
Ben

      reply	other threads:[~2011-04-26 22:35 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-26 18:26 Felipe Contreras
2011-04-26 18:43 ` Frank Terbeck
2011-04-26 19:06   ` Nikolai Weibull
2011-04-26 20:10     ` Frank Terbeck
2011-04-26 20:23   ` Felipe Contreras
2011-04-26 20:34     ` Mikael Magnusson
2011-04-26 20:57       ` Felipe Contreras
2011-04-26 20:59         ` Mikael Magnusson
2011-04-26 21:10           ` Felipe Contreras
2011-04-26 21:13             ` Mikael Magnusson
2011-04-26 21:35               ` Felipe Contreras
2011-04-26 22:03                 ` Nikolai Weibull
2011-04-26 22:25                   ` Felipe Contreras
2011-04-26 23:14                     ` Benjamin R. Haskell
2011-04-27  7:01                       ` Benjamin R. Haskell
2011-04-27  1:52                     ` gi1242+zsh
2011-04-27  6:11                     ` Nikolai Weibull
2011-04-27  8:30                       ` Felipe Contreras
2011-04-27  8:47                         ` Frank Terbeck
2011-04-27  9:06                           ` Felipe Contreras
2011-04-27 10:15                         ` Nikolai Weibull
2011-04-27 10:42                           ` Felipe Contreras
2011-04-27 11:14                             ` Nikolai Weibull
2011-04-27  4:19                 ` Bart Schaefer
2011-04-27  6:13                   ` Nikolai Weibull
2011-04-27 12:51                   ` Nikolai Weibull
2011-04-27 14:55                     ` Bart Schaefer
2011-04-27 18:36                       ` Nikolai Weibull
2011-04-30 14:37                     ` Simon Ruderich
2011-04-30 15:00                       ` Simon Ruderich
2011-05-02  9:59                       ` Nikolai Weibull
2011-05-03 13:59                         ` Nikolai Weibull
2011-04-26 21:52         ` Benjamin R. Haskell
2011-04-26 22:04           ` Felipe Contreras
2011-04-26 22:35             ` Benjamin R. Haskell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LNX.2.01.1104261822400.28316@hp \
    --to=zsh@benizi.com \
    --cc=felipe.contreras@gmail.com \
    --cc=ft@bewatermyfriend.org \
    --cc=mikachu@gmail.com \
    --cc=now@bitwi.se \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).