From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-40442-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 9818 invoked by alias); 28 Jan 2017 19:39:42 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 40442
Received: (qmail 11243 invoked from network); 28 Jan 2017 19:39:42 -0000
X-Qmail-Scanner-Diagnostics: from mercury.zanshin.com by f.primenet.com.au (envelope-from <schaefer@brasslantern.com>, uid 7791) with qmail-scanner-2.11 
 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1.  
 Clear:RC:0(64.84.47.142):SA:0(-0.0/5.0):. 
 Processed in 1.767444 secs); 28 Jan 2017 19:39:42 -0000
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-0.0 required=5.0 tests=SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.1
X-Envelope-From: schaefer@brasslantern.com
X-Qmail-Scanner-Mime-Attachments: |
X-Qmail-Scanner-Zip-Files: |
Received-SPF: pass (ns1.primenet.com.au: SPF record at ipost.com designates 64.84.47.142 as permitted sender)
Date: Sat, 28 Jan 2017 11:39:02 -0800 (PST)
From: Bart Schaefer <schaefer@brasslantern.com>
Reply-To: Bart Schaefer <schaefer@brasslantern.com>
To: zsh-workers@zsh.org
Subject: Re: [PATCH] isearch: do not use PAT_STATIC since we call zle hooks
In-Reply-To: <alpine.LRH.2.00.1701281048330.4560@toltec.zanshin.com>
Message-ID: <alpine.LRH.2.00.1701281129510.4560@toltec.zanshin.com>
References: <20170106172541.GA14113@fujitsu.shahaf.local2> <170108113358.ZM9462@torch.brasslantern.com> <20170108194021.18fb2011@ntlworld.com> <alpine.LRH.2.00.1701281048330.4560@toltec.zanshin.com>
User-Agent: Alpine 2.00 (LRH 1167 2008-08-23)
X-Face: "f/X=UCVgd*^c>+x(gMq0at?e:woX+;'snkkRzc3SX<0AZ (/PS4.M2hzGS9X:Qj]at_H/%a9K}:-eS<"v_7vX84PG9Bf Zpb`wI!I4geY=or+nWq`3CX`oq&TJR;g^ps|7(MH?jh;bs %vHJfCh5>a*6Re5m|Bidja\\o]>n\A)ib1:yX*T`zR(*h~ %tOw<~!D9{e6h!8M2:d8G2@K>y^1I_Vdy\d\MYe]z7c
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII

On Sat, 28 Jan 2017, Bart Schaefer wrote:

> ... back to deciding whether each individual use of PAT_STATIC is safe
> WRT signals and hooks.

Crimony, it looks like pretty much all of compctl.c is signal-UNsafe.

All the functions are static[*] except for the zmodload entry points.
Would it be asking for trouble to wrap all the builtin and widget
implementations of compctl in queue_signals()/unqueue_signals()?


[*] Or could be but for no apparent reason are not.