From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2]) by inbox.vuxu.org (OpenSMTPD) with ESMTP id 4dc00fee for ; Wed, 4 Mar 2020 19:31:00 +0000 (UTC) Received: (qmail 28279 invoked by alias); 4 Mar 2020 19:30:55 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 45511 Received: (qmail 27330 invoked by uid 1010); 4 Mar 2020 19:30:55 -0000 X-Qmail-Scanner-Diagnostics: from out2-smtp.messagingengine.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.102.2/25738. spamassassin: 3.4.2. Clear:RC:0(66.111.4.26):SA:0(-2.6/5.0):. Processed in 22.508722 secs); 04 Mar 2020 19:30:55 -0000 X-Envelope-From: d.s@daniel.shahaf.name X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: none (ns1.primenet.com.au: domain at daniel.shahaf.name does not designate permitted sender hosts) X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedruddtkedguddviecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhepofgfggfkjghffffhvffutgfgse htqhertderreejnecuhfhrohhmpedfffgrnhhivghlucfuhhgrhhgrfhdfuceougdrshes uggrnhhivghlrdhshhgrhhgrfhdrnhgrmhgvqeenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpegurdhssegurghnihgvlhdrshhhrghhrghfrdhn rghmvg X-ME-Proxy: X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.1.7-986-gfc2d493-fmstable-20200304v3 Mime-Version: 1.0 Message-Id: In-Reply-To: <939538FA-A90B-44DA-AF85-C50D0F516BA0@kba.biglobe.ne.jp> References: <82F8CDE0-C95C-4D31-ABFC-EBB3C97799F3@kba.biglobe.ne.jp> <1B509B1C-A670-482F-9D88-2145E15D03A1@kba.biglobe.ne.jp> <20200109131553.hqetnd45sc43z6xb@tarpaulin.shahaf.local2> <087AE8B9-35B0-4258-9626-AACA85471A07@kba.biglobe.ne.jp> <20200111201549.GA1264@tarpaulin.shahaf.local2> <3340070A-53DD-40F0-8363-A8C7D84702D3@kba.biglobe.ne.jp> <374cecf6-45d5-4688-861f-cc52017dbcea@www.fastmail.com> <321F9465-ABF9-465D-9242-7EF9A0EDDBED@kba.biglobe.ne.jp> <20200227132229.3e290918@tarpaulin.shahaf.local2> <84E062E9-E44F-4123-AC41-12E12071924E@kba.biglobe.ne.jp> <20200228141935.0b2d9748@tarpaulin.shahaf.local2> <939538FA-A90B-44DA-AF85-C50D0F516BA0@kba.biglobe.ne.jp> Date: Wed, 04 Mar 2020 19:29:37 +0000 From: "Daniel Shahaf" To: zsh-workers@zsh.org Subject: Re: [PATCH] find RLIM_NLIMITS correctly on Cygwin Content-Type: text/plain;charset=utf-8 Content-Transfer-Encoding: quoted-printable Jun T wrote on Tue, 03 Mar 2020 09:23 +00:00: >=20 > > 2020/02/28 23:19, Daniel Shahaf wrote: > >=20 > > Jun T wrote on Fri, 28 Feb 2020 17:42 +0900: > >>=20 > >> Currently each test chunk can have flags 'd' 'D' 'q' and 'f'. > >> We can add a new flag, say 'n', to make the failure not fatal. > >=20 > > If we add a new letter flag, we won't be able to make the non-fataln= ess > > specific to only one platform, though. We a new parameter, we'd be > > able to do =C2=AB[[ $OSTYPE =3D=3D cygwin* ]] && ZTST_failure_is_fat= al=3Dfalse=C2=BB. >=20 > I feel just letting the test fail may be enough, but if we are going > to add a new parameter/flag to ztst.zsh then it would be something lik= e > the patch below. In this case, how about letting the test fail, as you say? If in the future we change our mind about that, we can add the $ZTST_not_fatal flag then. > BTW, in B01cd.ztst, line 73: >=20 > # . d Don't diff stdout against the expected stdout. >=20 > What does this '.' mean? Is it just a typo? >=20 It was added in 08f084ecdeaeb19e595441e3e0203be4562bd285 (no X-Seq) by pws. The change isn't mentioned in the log message and broke alignment of the description column, so I guess it was a typo. > Test/B01cd.ztst | 7 +++++-- > Test/B12limit.ztst | 10 ++++++++++ > Test/ztst.zsh | 32 ++++++++++++++++++++++---------- > 3 files changed, 37 insertions(+), 12 deletions(-) I reviewed the diff (without out-of-hunk contexts) and have no comments.= Cheers, Daniel