From: "Allan Caffee" <allan.caffee@gmail.com>
To: "Zsh Workers" <zsh-workers@sunsite.dk>
Subject: Re: Minimal patch to _pdf
Date: Mon, 1 Dec 2008 21:21:57 -0500 [thread overview]
Message-ID: <b2e43f8f0812011821k21f4afb9y5631e35fd4bd34b1@mail.gmail.com> (raw)
In-Reply-To: <2d460de70812011726q578ad8bn778678171e2c6053@mail.gmail.com>
On Mon, Dec 1, 2008 at 8:26 PM, Richard Hartmann
<richih.mailinglist@gmail.com> wrote:
> See attached
>
I noticed that your patch modifies _pdf to complete for Okular. I
don't think you want to do that. Okular is used for viewing documents
for many different formats like PostScript and DVI files. By setting
its completion function to _pdf you are preventing it from completing
any of the other formats. It would be better to create a new function
which uses _pdf and the other relevant completion functions.
next prev parent reply other threads:[~2008-12-02 2:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-02 1:26 Richard Hartmann
2008-12-02 2:21 ` Allan Caffee [this message]
2008-12-02 9:09 ` Richard Hartmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b2e43f8f0812011821k21f4afb9y5631e35fd4bd34b1@mail.gmail.com \
--to=allan.caffee@gmail.com \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).