From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-26106-mason-zsh=primenet.com.au@sunsite.dk>
Received: (qmail 7220 invoked from network); 2 Dec 2008 02:22:11 -0000
X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00 autolearn=ham
	version=3.2.5
Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88)
  by ns1.primenet.com.au with SMTP; 2 Dec 2008 02:22:11 -0000
Received-SPF: none (ns1.primenet.com.au: domain at sunsite.dk does not designate permitted sender hosts)
Received: (qmail 65834 invoked from network); 2 Dec 2008 02:22:07 -0000
Received: from sunsite.dk (130.225.247.90)
  by a.mx.sunsite.dk with SMTP; 2 Dec 2008 02:22:07 -0000
Received: (qmail 5521 invoked by alias); 2 Dec 2008 02:22:02 -0000
Mailing-List: contact zsh-workers-help@sunsite.dk; run by ezmlm
Precedence: bulk
X-No-Archive: yes
X-Seq: 26106
Received: (qmail 5503 invoked from network); 2 Dec 2008 02:22:01 -0000
Received: from bifrost.dotsrc.org (130.225.254.106)
  by sunsite.dk with SMTP; 2 Dec 2008 02:22:01 -0000
Received: from fg-out-1718.google.com (fg-out-1718.google.com [72.14.220.158])
	by bifrost.dotsrc.org (Postfix) with ESMTP id CE1F080525B6
	for <zsh-workers@sunsite.dk>; Tue,  2 Dec 2008 03:21:57 +0100 (CET)
Received: by fg-out-1718.google.com with SMTP id e21so1897151fga.37
        for <zsh-workers@sunsite.dk>; Mon, 01 Dec 2008 18:21:57 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=gamma;
        h=domainkey-signature:received:received:message-id:date:from:to
         :subject:in-reply-to:mime-version:content-type
         :content-transfer-encoding:content-disposition:references;
        bh=ZtvyoRy1RmHMROoS+rR0/Z3RPhaZtsOFl6DJdHoDWlA=;
        b=nqqCSCrrRB1IBCo+VAdEFFrXIlilfzr79Ckn5ksafG7CReJJQh2T13h3as289iV5x5
         QR9qsYHxhP6W0fHY9hcbjsjxiJWIz0JtkEx2jMt/qTgL5uiHjh15J9T/AycSt9kIbmxU
         yx5tzIpCKiPvbwgf/MOPMA9xrpCTs4GMIdbxE=
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:to:subject:in-reply-to:mime-version
         :content-type:content-transfer-encoding:content-disposition
         :references;
        b=lWNPs5K1Kyom96+Rr6WIPpeo4TFwOm+mhC0lWTjvCtjnHSpi1tl8S7TvsTtmljKOBK
         ZR8yomlvtyY8nomxinPyfOkv088azVrso0WsdBGCFG8DlPylsX0q2S3quC1dEUHNobph
         9PyTdTfmPaC97NQ9EeYx6rRVvCccXJzH7SxzU=
Received: by 10.86.84.5 with SMTP id h5mr6846154fgb.49.1228184517340;
        Mon, 01 Dec 2008 18:21:57 -0800 (PST)
Received: by 10.86.95.12 with HTTP; Mon, 1 Dec 2008 18:21:57 -0800 (PST)
Message-ID: <b2e43f8f0812011821k21f4afb9y5631e35fd4bd34b1@mail.gmail.com>
Date: Mon, 1 Dec 2008 21:21:57 -0500
From: "Allan Caffee" <allan.caffee@gmail.com>
To: "Zsh Workers" <zsh-workers@sunsite.dk>
Subject: Re: Minimal patch to _pdf
In-Reply-To: <2d460de70812011726q578ad8bn778678171e2c6053@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <2d460de70812011726q578ad8bn778678171e2c6053@mail.gmail.com>
X-Virus-Scanned: ClamAV 0.92.1/8706/Tue Dec  2 01:08:47 2008 on bifrost
X-Virus-Status: Clean

On Mon, Dec 1, 2008 at 8:26 PM, Richard Hartmann
<richih.mailinglist@gmail.com> wrote:
> See attached
>

I noticed that your patch modifies _pdf to complete for Okular.  I
don't think you want to do that.  Okular is used for viewing documents
for many different formats like PostScript and DVI files.  By setting
its completion function to _pdf you are preventing it from completing
any of the other formats.  It would be better to create a new function
which uses _pdf and the other relevant completion functions.