Re: [PATCH] Remove _stgit completion script

["Peter Grayson" <pete@jpgrayson.net>]

Thank you for taking the time to consider and merge this patch.

On Mon, Oct 31, 2022, at 5:19 AM, Daniel Shahaf wrote:
> Peter Grayson wrote on Tue, Oct 25, 2022 at 16:43:21 -0400:
>> The StGit project ships its own zsh completion script which is more
>> complete and up-to-date than those shipped with zsh.
>> 
>> https://github.com/stacked-git/stgit/blob/master/completion/stgit.zsh
>> 
>
> + I see that completion script gets updated in lockstep with stg(1)'s
>   argv parser.

Yes, maintaining that tight coupling between stg(1)'s command line
parsing and its comprehensive completion script has been important for
StGit development velocity. Although, maybe less velocity on the horizon
post StGit 2.0.

> + Given the two projects' release schedules it seems safe to assume that
>   by zsh's next release stg 2.0 will have been released as well, so most
>   users won't end up in a situation where they have neither _stgit nor
>   stgit.zsh.

StGit has been releasing its own zsh completion script since at least 1.0,
so there is not even a minor release timing concern.
 
> + No objections in a week.
>
> - _stgit and stgit.zsh are licenced differently.
>
> Being licenced under the same terms as zsh itself seems to be outweighed
> by not being regularly updated.  So, I've pushed this.  The last version
> is of course still available in our version control history.

If at any point we think it makes sense to migrate StGit's completion
script [back] to the zsh project, I would be happy to relicense.

> StGit is also used by vcs_info, here:
>
> https://github.com/zsh-users/zsh/blob/b76dcecfe3461aa9a9e29dffe2484f097611f9ff/Functions/VCS_Info/Backends/VCS_INFO_get_data_git#L187-L194
>
> (There doesn't seem to be StGit-specific code elsewhere in the file or
> in the sibling file VCS_INFO_detect_git.)
>
> Any chance that someone who uses both StGit and zsh could review that?
> That code is supposed to populate $gitmisc (and thus the %m expando)
> with information about pushed and not-yet-pushed patches.

Thanks for pointing this out--I didn't know about it. I've taken a look
and my conclusion is that the StGit patch state interrogation currently
found in VCS_INFO_get_data_git should also just simply be removed. I'll
send another patch shortly with the rationale in the commentary.

Cheers,
Pete