From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 19617 invoked from network); 1 Nov 2022 03:01:25 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 1 Nov 2022 03:01:25 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1667271685; b=raWlC9VO3ClByOdT1aOeDCOJp/O/JLh5kf7q4/zIatHmV8e8kNXKHT7B49tL+/I+GqjzA8zFTB 3uxv0yj+Rn9P3hgB2mBWI071sRX3CgaVyXWkV42DOJ2csntp9TddbtMPAvtkdaRTiWyv4aiRPT VKyRt+lTYaXpNEa1dqfT7j1h6XSfXaRkBPBTR8aaD/HpGPXv5YxvER64WXYIpbnrn9wZ8uzuqe 3L6AeN2S3G8lS2PAmyi8DzA01TBCZue68QO1R+buVY8x2t1+zCDcwByp0Vc30CG98DbArpa6iP nOXETsgFAYB4WzV6ty6Egn9jCxf6QY148G5WWQCQp111Nw==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (out2-smtp.messagingengine.com) smtp.remote-ip=66.111.4.26; dkim=pass header.d=jpgrayson.net header.s=fm2 header.a=rsa-sha256; dkim=pass header.d=messagingengine.com header.s=fm3 header.a=rsa-sha256; dmarc=none header.from=jpgrayson.net; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1667271685; bh=t+PW8AwUWd3MQOlGe6HKC0ydcWZFFN4xBOrDADjFlRk=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Type:Subject:Cc:To:From:Date:References:In-Reply-To: Message-ID:MIME-Version:DKIM-Signature:DKIM-Signature:DKIM-Signature; b=CJK6cMAFHeaMC5s/GlrSIjbvMIg9imAnDuKzyjo+RdrtFCR9up1Hiyj+ozksDh8EkKUWLLcIaP 4uCpzO6Aa+lz+xj1pF7sSuvtyFfaodvCvto+/Yh7QuAoa9iCwF4D+1pvnUT8SsYqOX2CSCHovG zPKC+H3Gf235bZQHQnQXu0AxHX16b/fKNVVZUOUXRvCK5dWpruTzI7jPRye1B+bhLH9uE6iWj/ uZQPRcJ8Pwkk4vx9IXc/Myt0vmuTRCw+HJjeL++eeqThSoEpMSdeHx67zhRNRTvEXAu9XgQWYX OrdexeG3cM/JKLzMkpDlTloXC88IVizqPgmhtWXpl6bacw==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Type:Subject:Cc:To:From:Date: References:In-Reply-To:Message-Id:Mime-Version:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=swKNBZd8SWMX9K0Tb/VpcGtx4yFnJtCd4GPSPzCz1us=; b=NTzXUR3iV3zvhL80S9vR/31HeZ yT11zqLpgETB1q3UzR6phRtTiagmLolwuKaf1uT5BKKtdIfRNKrWdLBYkEPBMPvPrsPgFyhZr87nq AJNc3Bmp0EqVADWpEcIQQL98+RfU2CkCdTmpemef0EZEZw28bCtn9hCS6dPQEVK1ITYMNkLdKPMRg y3jx4kL42iMVvmjZs49K0+shC0aQr/6aD8CJcJje6rKTreIfcv6ORx8WkRD/vLK6jwWPBqc+YobzM dgqodqbltAZpZdHbVjUhKvTxKT5WKnLJ7JkbmiFe1+DlJxvln252KysHr1aFqZ21JpF8vEQxn54ow bb1qThdw==; Received: by zero.zsh.org with local id 1ophWm-0009we-J2; Tue, 01 Nov 2022 03:01:24 +0000 Authentication-Results: zsh.org; iprev=pass (out2-smtp.messagingengine.com) smtp.remote-ip=66.111.4.26; dkim=pass header.d=jpgrayson.net header.s=fm2 header.a=rsa-sha256; dkim=pass header.d=messagingengine.com header.s=fm3 header.a=rsa-sha256; dmarc=none header.from=jpgrayson.net; arc=none Received: from out2-smtp.messagingengine.com ([66.111.4.26]:33173) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_256_GCM_SHA384:256) id 1ophWE-00092v-1P; Tue, 01 Nov 2022 03:00:51 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 4FE9E5C007C; Mon, 31 Oct 2022 23:00:48 -0400 (EDT) Received: from imap48 ([10.202.2.98]) by compute4.internal (MEProxy); Mon, 31 Oct 2022 23:00:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jpgrayson.net; h=cc:cc:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1667271648; x=1667358048; bh=sw KNBZd8SWMX9K0Tb/VpcGtx4yFnJtCd4GPSPzCz1us=; b=JcGHcz+ClYPv0L2jUC 7so2Mysy6nDy11r79TGJMZP6ti4mLWvBsrpxKIfG1V2kelPcWjrHeYU/l6ukIjZX XSx6SZ+wRFcl9WgqYrtOy/dcUGEJiBE2NgID4pbtheReemmG5/Zli1hvM+Ks7mYv c6K6+Ct3nuJzMd4jZNHruJXXboGY+1x0lL3xwWy+vvfF+SR+H6A2D8zGXp9lzAvA uuFMsYdo2zYH50QR2CIpBOsIFWiLli5deUw7p11LvU3NzfFYtbpxHH5z3/I1en8D cQnTUNK4qMpFdi9yNRIT2pj1tMTjskUkHrDGFFIzWJGbdNLAYVtBNlQJhOJeFEM0 c3gw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1667271648; x=1667358048; bh=swKNBZd8SWMX9K0Tb/VpcGtx4yFn JtCd4GPSPzCz1us=; b=sns3ELilsPvb5Di9sQax+1oAVYxPJ+JJiBjuDQZvY8SJ sITaf4rmGbMxnFtDIEKkhSrujEf2aOYwGYEqOeusV4nNF5YiZRmYg8FVb6RZStqg jTtx0hfX+mKB63nVn6Vig1dKTSSF+yerlHTlaujp/n2woFuKZEOFSIfalNQ7MTX6 LC9RoHVCR8Oo6fB/W6ZOAds1wRQTHmPp+kmmUJGoMzkjnzuJl+04/tpECLEXR6mm ylDCW5xMO3kSNe9L9xqOlZAkBPBfHshiHq69XOG6ftfAwgI2dRWz9P5GxdNW3XOW cIHCQ+BLhfqhMyRrIcUpTT7ROlfaU6FGcFXqr5krOA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrudeggdehgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhepofgfggfkjghffffhvfevufgtsehttd ertderredtnecuhfhrohhmpedfrfgvthgvrhcuifhrrgihshhonhdfuceophgvthgvsehj phhgrhgrhihsohhnrdhnvghtqeenucggtffrrghtthgvrhhnpeffgedvhfejheeiveduhf elhffggfeutdekgffgieffffevledtueeuhfffueevkeenucffohhmrghinhepghhithhh uhgsrdgtohhmnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepphgvthgvsehjphhgrhgrhihsohhnrdhnvght X-ME-Proxy: Feedback-ID: iefe944c0:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id E0FB031A0063; Mon, 31 Oct 2022 23:00:47 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.7.0-alpha0-1087-g968661d8e1-fm-20221021.001-g968661d8 Mime-Version: 1.0 Message-Id: In-Reply-To: <20221031091933.GE27622@tarpaulin.shahaf.local2> References: <20221025204319.1709205-1-pete@jpgrayson.net> <20221031091933.GE27622@tarpaulin.shahaf.local2> Date: Mon, 31 Oct 2022 23:00:27 -0400 From: "Peter Grayson" To: "Daniel Shahaf" Cc: zsh-workers@zsh.org Subject: Re: [PATCH] Remove _stgit completion script Content-Type: text/plain X-Seq: 50856 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: , List-Subscribe: , List-Unsubscribe: , List-Post: List-Owner: List-Archive: Thank you for taking the time to consider and merge this patch. On Mon, Oct 31, 2022, at 5:19 AM, Daniel Shahaf wrote: > Peter Grayson wrote on Tue, Oct 25, 2022 at 16:43:21 -0400: >> The StGit project ships its own zsh completion script which is more >> complete and up-to-date than those shipped with zsh. >> >> https://github.com/stacked-git/stgit/blob/master/completion/stgit.zsh >> > > + I see that completion script gets updated in lockstep with stg(1)'s > argv parser. Yes, maintaining that tight coupling between stg(1)'s command line parsing and its comprehensive completion script has been important for StGit development velocity. Although, maybe less velocity on the horizon post StGit 2.0. > + Given the two projects' release schedules it seems safe to assume that > by zsh's next release stg 2.0 will have been released as well, so most > users won't end up in a situation where they have neither _stgit nor > stgit.zsh. StGit has been releasing its own zsh completion script since at least 1.0, so there is not even a minor release timing concern. > + No objections in a week. > > - _stgit and stgit.zsh are licenced differently. > > Being licenced under the same terms as zsh itself seems to be outweighed > by not being regularly updated. So, I've pushed this. The last version > is of course still available in our version control history. If at any point we think it makes sense to migrate StGit's completion script [back] to the zsh project, I would be happy to relicense. > StGit is also used by vcs_info, here: > > https://github.com/zsh-users/zsh/blob/b76dcecfe3461aa9a9e29dffe2484f097611f9ff/Functions/VCS_Info/Backends/VCS_INFO_get_data_git#L187-L194 > > (There doesn't seem to be StGit-specific code elsewhere in the file or > in the sibling file VCS_INFO_detect_git.) > > Any chance that someone who uses both StGit and zsh could review that? > That code is supposed to populate $gitmisc (and thus the %m expando) > with information about pushed and not-yet-pushed patches. Thanks for pointing this out--I didn't know about it. I've taken a look and my conclusion is that the StGit patch state interrogation currently found in VCS_INFO_get_data_git should also just simply be removed. I'll send another patch shortly with the rationale in the commentary. Cheers, Pete