From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,T_SCC_BODY_TEXT_LINE, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 11650 invoked from network); 17 Apr 2022 17:09:43 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 17 Apr 2022 17:09:43 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1650215384; b=k9Ays5Lwrxidu1Y+ZkbDAZCOLq1gKfdtOHCIp8jUcOGkF+cfsiqWT7CIiTbHx5uq55jQza2pfy T0O6C8vt5Q4U9JiIIVE3k/vSbuTSG3Q7kXOis5TcHKGjawb7WteDrcpyHPTyqNyaP+g3/Sj5Or p2GZONzofBW9zWMYN+18vk6rpWmJbmzykBiFQ4Ps6sG9yclavS0KYFMt4tWdwKgsg1Rnkz3Bab ssR+giQLF5Qcag/d4oJYtQqGTgb+nVlpKD3Nv+c2SU5CKfvHtyZDd5OtXBAYajftt+Pjvc8Xak frCHgaWBWSLYZHH5mLLkgOF9qPnX8VRgP787CU4KwD5jGA==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (out5-smtp.messagingengine.com) smtp.remote-ip=66.111.4.29; dkim=pass header.d=daniel.shahaf.name header.s=fm3 header.a=rsa-sha256; dkim=pass header.d=messagingengine.com header.s=fm1 header.a=rsa-sha256; dmarc=none header.from=daniel.shahaf.name; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1650215384; bh=wLiRlVfy3QqZcidOYYOnod5ANQWDWmG14eKU4lI7pe4=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Transfer-Encoding:Content-Type:Subject:Cc:To:From: Date:References:In-Reply-To:Message-ID:MIME-Version:DKIM-Signature: DKIM-Signature:DKIM-Signature; b=P96ZCfp6UBaB6RwHBF8LUAI7CedbCM1vb/JHWlooguAtP0Z5pq+O5JjsLAboRxbwh35qgts0oF o6ndlcP+f/EuajiONWUAsHFruLv1UwY5SMjKvcVvRUmA9WyWaV2o465EYScTryd0sNAm4s91lE mIXyYP3SsViGJZVVjD8R3YD0LvFwedCW7Z/yxx9zs+H7JGYCfQbepkPV7laEbHagCtNYxFsR7v 7cGRNAhcdi+YwEOopy35WPoDHlnVf2m1Ma9V6GF3PwSN4VYK0w8HNOcMOP+TkFUSmKFJMuGGVR QgdbvOJGmhC6ed7FERiEyFeCNeu8qWwJmMVuCVmAyyhz6g==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Transfer-Encoding: Content-Type:Subject:Cc:To:From:Date:References:In-Reply-To:Message-Id: Mime-Version:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=bIOYTJTKkQdNDa1u+4tqj74iYhkaS8n7F1S/EuTSYig=; b=ijD/Jyv7yfeHIu1btV0VCs56U3 ZsfOtIGOia5A+eJWW78y0MvGV7nme/ZW8gzKnclk9gSQJ5NZUvTOFigawosTb1H1iEAQfxm5dDrWY NPYSzNhq4qiolvDNZs1MlSgNX38MrJB3I9ABwVgCeEnV3C3FwvUnStGr5zWTILeAX8koNbewnIT3J vAbJxiGJ/KOvjyqBCj85y0jgDa4lup3r7leKarLCWQgdldh3fAJl7Bb/wgyoLBLjcL9fIx0I7Ua4h goLsSxFDy90P47lhvfNXD6N66UJKimgk6IDkvSnRiOdLuYtnxHesltQHr3XDd/3ks4xUdN3wKFUdG eLmBJPKw==; Received: from authenticated user by zero.zsh.org with local id 1ng8P8-000Ciz-Bm; Sun, 17 Apr 2022 17:09:42 +0000 Authentication-Results: zsh.org; iprev=pass (out5-smtp.messagingengine.com) smtp.remote-ip=66.111.4.29; dkim=pass header.d=daniel.shahaf.name header.s=fm3 header.a=rsa-sha256; dkim=pass header.d=messagingengine.com header.s=fm1 header.a=rsa-sha256; dmarc=none header.from=daniel.shahaf.name; arc=none Received: from out5-smtp.messagingengine.com ([66.111.4.29]:35109) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_256_GCM_SHA384:256) id 1ng8OY-000CNq-2v; Sun, 17 Apr 2022 17:09:06 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 639E45C011C; Sun, 17 Apr 2022 13:09:05 -0400 (EDT) Received: from imap46 ([10.202.2.96]) by compute2.internal (MEProxy); Sun, 17 Apr 2022 13:09:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= daniel.shahaf.name; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; t=1650215345; x=1650301745; bh=bIOYTJTKkQ dNDa1u+4tqj74iYhkaS8n7F1S/EuTSYig=; b=sO64UvoXYomOE2DMYQI3CzJdB9 +FZ0p2BKglIdAb+s+JDKebamJmnruAJdYYBwYJfou0gZJJteSd5hlS7EITWG31ve hYflDMs0GzgJR6Tu0/0eP16DFHJ3ITp4MYsfrJu23LUh2vTXsyx5XXtlAgytDfQk teJjvCPFi0R9iiVpg4lnbopSAlIKaQoY4b9oXilVeicGL9oZV+8t2nnBq0Ys7yJs unky5mQQ0SF/9MNkN8TLyVQF6J2tu5MIKOvzy17d08Ph65G7IP7d9zL5DCvr2hyH lQ/Oi61EjBWNX2i0GzK54Wh9QWzaS99+dWlU9r46vOhzQTTDzM0C6NjYqlHw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1650215345; x=1650301745; bh=bIOYTJTKkQdND a1u+4tqj74iYhkaS8n7F1S/EuTSYig=; b=nYnOghDDeVVM1TyHaIauegEK4PUip N34yr9TZ7aen/Y99fwbV2w1q3oySgZ6l+tSVzLxXiiTBkA62ODIplg8pOntGd0Uy XheNwmUHsq+Q7lgzTdy8kBAmsrnB32kscscg+xd8n6N1ZEJQBK6o7gK2elcYNEbM +c7HUjc+dAMB/59Ngsu+PJzY6GSccBZI2t3AnCsNLh7VOPfF5+0GaAI133R9yllO dKaxWYFxPCAu29evH+WJnuHBKXt15LjlrGQa7MkM6kxwXr+VUqOAIYVRl3eS9fRp xPqUAD5R8LoBzuS+arbmnzGsEgpBDO30HSYhjpwRjcJ09NM8sKkA0Vkyg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudelledguddufecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhepofgfggfkjghffffhvffutgfgse htqhertderreejnecuhfhrohhmpedfffgrnhhivghlucfuhhgrhhgrfhdfuceougdrshes uggrnhhivghlrdhshhgrhhgrfhdrnhgrmhgvqeenucggtffrrghtthgvrhhnpeefhfekfe evieelleehiefftdekudejledvhfdtjedtgeegvdeuffefleehhfdvgfenucevlhhushht vghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegurdhssegurghnihgvlh drshhhrghhrghfrdhnrghmvg X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id 211DA1EE007B; Sun, 17 Apr 2022 13:09:05 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.7.0-alpha0-387-g7ea99c4045-fm-20220413.002-g7ea99c40 Mime-Version: 1.0 Message-Id: In-Reply-To: References: <25170.64465.301441.247673@lwm.klanderman.net> <87fsmk2a03.fsf@lwm.klanderman.net> <87czho2967.fsf@lwm.klanderman.net> <871qy0yzp4.fsf@lwm.klanderman.net> Date: Sun, 17 Apr 2022 17:08:44 +0000 From: "Daniel Shahaf" To: "Zsh hackers list" Cc: "Greg Klanderman" Subject: Re: using trap function to cleanup and exit? Content-Type: text/plain;charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Seq: 50072 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: Bart Schaefer wrote on Thu, 14 Apr 2022 23:35 +00:00: > On Thu, Apr 14, 2022 at 2:29 PM Bart Schaefer wrote: >> >> I've therefore included cleaning up the BUGS file and reversing the >> sense of that test > > I suppose I should also have reversed the sense of the test descriptio= n. > > diff --git a/Test/C03traps.ztst b/Test/C03traps.ztst > index 3bd2958cb..8d1283552 100644 > --- a/Test/C03traps.ztst > +++ b/Test/C03traps.ztst > @@ -901,7 +901,7 @@ F:Must be tested with a top-level script rather > than source or function > fn trap1 trap2 > echo out2 > ' > --:(workers/44007) function execution continues after 'exit' in trap > +-:'exit' in trap causes calling function to return Change =C2=AB-=C2=BB to =C2=AB0=C2=BB (or whatever exit code is appropri= ate)? When a test is XFail ('f' flag), I like to write its expectations as minimally as possible, in order to make it easy for the test to XPass ("was expected to fail, but passed"); however, once the bug is fixed and the test starts to pass (=3D without 'f'), expectations can be tightened. Not awake enough to review the C changes right now, sorry. Cheers, Daniel > >out1 > >fn1 > >trap1