From: "Lawrence Velázquez" <larryv@zsh.org>
To: "Daniel Shahaf" <d.s@daniel.shahaf.name>
Cc: zsh-workers@zsh.org
Subject: Re: PM_TAGGED and PM_TAGGED_LOCAL being set simultaneously (functions -T -t f)
Date: Sun, 16 May 2021 10:50:34 -0400 [thread overview]
Message-ID: <bbb5c047-a827-4fb5-8a6d-40b11a3dcc4c@www.fastmail.com> (raw)
In-Reply-To: <20210415205806.GD6669@tarpaulin.shahaf.local2>
Hi Daniel,
On Thu, Apr 15, 2021, at 4:58 PM, Daniel Shahaf wrote:
> I figured I'd write a test to at least ensure we don't change the
> behaviour by accident (it would be too easy to change the if/else chain
> that tests the bitflags), but ran into another question along the way.
> Look at the first added test:
>
> diff --git a/Test/E02xtrace.ztst b/Test/E02xtrace.ztst
> index 10e8b8886..520b7745f 100644
> --- a/Test/E02xtrace.ztst
> +++ b/Test/E02xtrace.ztst
> @@ -225,3 +225,38 @@
> >the definition didn't execute it
> >runs
>
> + f() g
> + g() :
> + functions -t f
> + f
> +0:functions -t smoke test #1
> +?+f:4> g
> +?+g:4> :
> +
> + f() g
> + g() { () : }
> + functions -t f
> + f
> +0:functions -t smoke test #2
> +?+f:4> g
> +?+g:0> '(anon)'
> +?+(anon):0> :
> +
> + f() g
> + g() :
> + (
> + functions -T f
> + functions -t f
> + f
> + )
> + (
> + functions -t f
> + functions -T f
> + f
> + )
> +0:ensure the behaviour of 'functions -Tt f' doesn't change surreptitiously
> +?+f:6> g
> +?+f:11> g
> +F:If this test fails, the new behaviour may be
> +F:workers/48591.
> +
Was this something you were planning on committing?
vq
next prev parent reply other threads:[~2021-05-16 14:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-14 15:03 Daniel Shahaf
2021-04-14 15:22 ` Peter Stephenson
2021-04-15 16:21 ` Daniel Shahaf
2021-04-15 18:38 ` Peter Stephenson
2021-04-15 20:58 ` Daniel Shahaf
2021-05-16 14:50 ` Lawrence Velázquez [this message]
2021-05-18 1:57 ` Daniel Shahaf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bbb5c047-a827-4fb5-8a6d-40b11a3dcc4c@www.fastmail.com \
--to=larryv@zsh.org \
--cc=d.s@daniel.shahaf.name \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).