From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2]) by inbox.vuxu.org (OpenSMTPD) with ESMTP id fe08b75d for ; Thu, 21 Mar 2019 11:58:38 +0000 (UTC) Received: (qmail 11451 invoked by alias); 21 Mar 2019 11:58:22 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 44154 Received: (qmail 5334 invoked by uid 1010); 21 Mar 2019 11:58:22 -0000 X-Qmail-Scanner-Diagnostics: from wout1-smtp.messagingengine.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.101.1/25393. spamassassin: 3.4.2. Clear:RC:0(64.147.123.24):SA:0(-2.6/5.0):. Processed in 5.124253 secs); 21 Mar 2019 11:58:22 -0000 X-Envelope-From: d.s@daniel.shahaf.name X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: none (ns1.primenet.com.au: domain at daniel.shahaf.name does not designate permitted sender hosts) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= daniel.shahaf.name; h=mime-version:message-id:in-reply-to :references:date:from:to:subject:content-type; s=fm2; bh=Kd1Yqzm FKbSl0jwuCtMM7tZdakc9cTWpl0CvpFoMK0E=; b=N1aoqJj07vq7xKw1t+/Rw7m kueltVe5A0N3DO40TxwMYSUM7XUTyHDulQ4MSjB/onGoXyb577V4d+Sh86amG1yf JNTQrBVSBgdPWJkwCJnQQh51/XCc6zdZLBCKa73qww+WzBnvaLk/bRdVWsIBDs+t HTyIAnyVVrrDSYqyeRPnT3MA9iBXkVxPBtYyTcc0ayEcwkaqNnHOFo24sVOzcfmU 7TXqLjtH+zeikVKWeKX/uwlndnIPYdWPtLRQIUfuZ9MP+QeMmH7zkK362+gpJgL2 bD/vemVAgErj1yED1XZKcF9oRrUD67XFoNClPmMxVpLvB8UdKt6FT1MJXp94y0A= = DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=Kd1Yqz mFKbSl0jwuCtMM7tZdakc9cTWpl0CvpFoMK0E=; b=EqH2d0jXwS1CpAxIjP3zN9 1XYYURZzDDZlti74pfLhNy95wqcwLNMS7OgSMdkCHcSMJSlCnZ6AJmKdXjVwi6Hn hfk1srM5+4s1pdmZJdtbEGt3+67LwDuW5cs3Zlz823P43uId1+3KIph+ZOXCVNHE l03Rv/82uWnM8wEoT7/vlS56jQO6h8xs1GdDFpc10WtzOI5Ysz1fB5L0qw26LzfO f0OKQIl/vwql+N/Gm/iZBo3SU9ikr3U4uGnsN1IS62xGNDn/0Vk/adNy9S/+INhP CdEp2F3rgH9alJ6IJTBq9Nrun6K6fZXWDJhL6RlZv1h5nYER7cdpYl8YXC3WPBtA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrieelgddvtdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhepofgfggfkjghffffhvffutgesthdtre dtreertdenucfhrhhomhepfdffrghnihgvlhcuufhhrghhrghffdcuoegurdhssegurghn ihgvlhdrshhhrghhrghfrdhnrghmvgeqnecurfgrrhgrmhepmhgrihhlfhhrohhmpegurd hssegurghnihgvlhdrshhhrghhrghfrdhnrghmvgenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.1.5-976-g376b1f3-fmstable-20190314v3 Mime-Version: 1.0 X-Me-Personality: 3897223 Message-Id: In-Reply-To: <20190321001636.GA57147@CptOrmolo.darkstar> References: <20190320020511.GA6739@CptOrmolo.darkstar> <20190320033815.GA22718@CptOrmolo.darkstar> <20190320125238.GA48465@CptOrmolo.darkstar> <20190320130523.rwpxbzi4u66i2srz@tarpaulin.shahaf.local2> <20190321001636.GA57147@CptOrmolo.darkstar> Date: Thu, 21 Mar 2019 07:57:38 -0400 From: "Daniel Shahaf" To: zsh-workers@zsh.org Subject: Re: [PATCH] _pick_variant: Update builtin check Content-Type: text/plain Matthew Martin wrote on Thu, 21 Mar 2019 00:17 +00:00: > On Wed, Mar 20, 2019 at 01:05:23PM +0000, Daniel Shahaf wrote: > > Matthew Martin wrote on Wed, Mar 20, 2019 at 07:52:39 -0500: > > > +builtin_precommands=(- builtin eval exec nocorrect noglob time) > > > > May I suggest a comment here documenting the semantics of this variable? > > For example, why doesn't it list the 'command' precommand (presumably > > becaus that one doesn't preserve builtins, but this info should be in > > the comment, not in the list archives)? > > How's > +# Precommands which allow the command to be builtin (unlike command and sudo). > +local -ar builtin_precommands=(- builtin eval exec nocorrect noglob time) I understand what you mean in the context of this thread, but I think the two uses of the term 'command' might be confusing to someone who opens the file in a year or three. How about: # Precommands which allow their wrapped command to be a builtin. # All of these are necessarily builtins or reserved words themselves, but not all builtin precommands are listed here: for one, the 'command' builtin is excluded. Cheers, Daniel