From: "Daniel Shahaf" <d.s@daniel.shahaf.name>
To: "Vin Shelton" <acs@alumni.princeton.edu>,
"Marlon Richert" <marlon.richert@gmail.com>
Cc: "Zsh Hackers' List" <zsh-workers@zsh.org>,
"Jun T" <takimoto-j@kba.biglobe.ne.jp>
Subject: Re: Y01 Test Failure on Arch
Date: Sun, 04 Apr 2021 17:02:02 +0000 [thread overview]
Message-ID: <bf2c30eb-1a37-4c53-a019-a6fceb6625d4@www.fastmail.com> (raw)
In-Reply-To: <CACeGjnUdhkOfFysohkDxZP6=-dBwv_Rhe0Y=fJF62UEWM5C4OQ@mail.gmail.com>
Vin Shelton wrote on Sun, 04 Apr 2021 14:00 +00:00:
>
>
> On Sun, Apr 4, 2021 at 12:05 AM Jun. T <takimoto-j@kba.biglobe.ne.jp> wrote:
> >
> > > 2021/04/03 20:32, Vin Shelton <acs@alumni.princeton.edu> wrote:
> > >
> > > Ping. The failure still occurs.
> >
> > Do you mean it still fails with my patch?
>
> No, I mean your patch hasn't been applied. ISTR you also expressed
> concerns that your patch wasn't certainly the right way to go. Also,
> *why* was the test change necessary in the first place?
> Philosophically, I think the tests should reflect the current behavior
> of the shell - one doesn't change the test unless one understands why.
Vin, thanks for the nudges and for the review.
Marlon, the failure is due to workers/48214, which is yours. Thoughts?
Cheers,
Daniel
next prev parent reply other threads:[~2021-04-04 17:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-31 13:40 Vin Shelton
2021-04-01 4:05 ` Jun T
2021-04-03 11:32 ` Vin Shelton
2021-04-04 4:05 ` Jun. T
2021-04-04 14:00 ` Vin Shelton
2021-04-04 17:02 ` Daniel Shahaf [this message]
2021-04-05 14:58 ` Marlon Richert
2021-04-06 4:23 ` Jun T
2021-04-06 11:38 ` Marlon
2021-04-06 9:53 ` Oliver Kiddle
2021-04-04 18:27 ` Bart Schaefer
2021-04-05 0:39 ` Vin Shelton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bf2c30eb-1a37-4c53-a019-a6fceb6625d4@www.fastmail.com \
--to=d.s@daniel.shahaf.name \
--cc=acs@alumni.princeton.edu \
--cc=marlon.richert@gmail.com \
--cc=takimoto-j@kba.biglobe.ne.jp \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).