From: Chris Down <chris@chrisdown.name>
To: zsh-workers@zsh.org
Cc: Daniel Shahaf <d.s@daniel.shahaf.name>
Subject: [PATCH v3 1/3] builtins: kill: Add basic test suite
Date: Mon, 17 Feb 2020 10:11:46 -0500 [thread overview]
Message-ID: <c02a0a26bf4c82b1e227053337a4c71525504574.1581952273.git.chris@chrisdown.name> (raw)
This is not totally comprehensive, but at least it's a start for the
core functionality. In the next commits, we'll also use this base to add
some regression tests.
---
Test/B11kill.ztst | 60 +++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 60 insertions(+)
create mode 100644 Test/B11kill.ztst
diff --git a/Test/B11kill.ztst b/Test/B11kill.ztst
new file mode 100644
index 000000000..c254b0925
--- /dev/null
+++ b/Test/B11kill.ztst
@@ -0,0 +1,60 @@
+# Tests for the kill builtin.
+#
+# The exit codes 11 and 19 in this file don't mean anything special, they're
+# just an exit code which is specific enough that the failure of `kill` itself
+# can be differentiated from exiting due to executing a trap.
+
+%test
+
+# Correct invocation
+
+ if zmodload zsh/system &>/dev/null; then
+ (
+ trap 'exit 19' TERM
+ kill $sysparams[pid]
+ )
+ else
+ ZTST_skip='Cannot zmodload zsh/system, skipping kill with no sigspec'
+ fi
+19:kill with no sigspec
+
+
+ if zmodload zsh/system &>/dev/null; then
+ (
+ trap 'exit 11' USR1
+ kill -USR1 $sysparams[pid]
+ )
+ else
+ ZTST_skip='Cannot zmodload zsh/system, skipping kill with sigspec'
+ fi
+11:kill with sigspec
+
+# Incorrect invocation
+
+ (
+ kill a b c
+ )
+3:kill with multiple wrong inputs should increment status
+?(eval):kill:2: illegal pid: a
+?(eval):kill:2: illegal pid: b
+?(eval):kill:2: illegal pid: c
+
+ (
+ kill -INT a b c
+ )
+3:kill with sigspec and wrong inputs should increment status
+?(eval):kill:2: illegal pid: a
+?(eval):kill:2: illegal pid: b
+?(eval):kill:2: illegal pid: c
+
+ (
+ kill
+ )
+1:kill with no arguments
+?(eval):kill:2: not enough arguments
+
+ (
+ kill -INT
+ )
+1:kill with sigspec only
+?(eval):kill:2: not enough arguments
--
2.25.0
next reply other threads:[~2020-02-17 15:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-17 15:11 Chris Down [this message]
2020-02-17 15:12 ` [PATCH v3 2/3] builtins: kill: Add `kill ''` regression test with explicit sigspec Chris Down
2020-02-17 15:12 ` [PATCH v3 3/3] builtins: kill: Do not signal current process group when pid is empty Chris Down
2020-02-18 13:04 ` [PATCH v3 2/3] builtins: kill: Add `kill ''` regression test with explicit sigspec Daniel Shahaf
2020-02-18 15:26 ` Chris Down
2020-02-18 16:42 ` Daniel Shahaf
2020-02-18 18:50 ` Chris Down
2020-02-18 19:37 ` Daniel Shahaf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c02a0a26bf4c82b1e227053337a4c71525504574.1581952273.git.chris@chrisdown.name \
--to=chris@chrisdown.name \
--cc=d.s@daniel.shahaf.name \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).