From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI autolearn=ham autolearn_force=no version=3.4.4 Received: from zero.zsh.org (zero.zsh.org [IPv6:2a02:898:31:0:48:4558:7a:7368]) by inbox.vuxu.org (Postfix) with ESMTP id E45F722151 for ; Tue, 28 May 2024 17:41:33 +0200 (CEST) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1716910893; b=HJ7l2wWi1VXAbEUSKGjYlyBONeucrOcroboYMe2L3Nz+S8ym+DMaUEksUU5QjI6LeozU/Yg9jv any7wQPtnbAgcs+67Z1KJuyxZ4d71naRMAgxZSIXQlRBvcT66H1/vBJayrDpgbqUAsmK+rbl4w /CkX9uyRbqkSDBn0KN6skG7Zregyc9YWYjYAwJJMqbEWgHXgEFZ7Ipm6r0WCpsHZgrhEjnSRA1 8t3CbmYRG6AC3VeGRnIpUqrRoypVGj2Bz2ZrkYqJ+y5qffxGH09QGMwVE8dJFfxVt5usk/uDHN iP78ZSOx7NIOHHp0GORy7GanZVLKjEGAbbH+bR8A3zl21g==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (out-175.mta0.migadu.com) smtp.remote-ip=91.218.175.175; dkim=pass header.d=fugi.dev header.s=key1 header.a=rsa-sha256; dmarc=pass header.from=fugi.dev; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1716910893; bh=Fpq3nsWMOsurxEIvjqfybdzoMz9qLbD35QV3o6J6SWc=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:DKIM-Signature: DKIM-Signature; b=Z37MdgjnvzIdW+UnM7bpE6ERTQIg+vNFA0OkqOz1n6tZiS2O4cknPWgs3GrWGVGAOaVJ1qYI5w QwsTwg/RqK/EG7LUvo6DQyhcEogxlY6xHXJD02STG1TFv0cIC0cxR8pDfeOgzTncatANa5CU6r qPzZ9sTaHWc750TFp0O1+pPnVr176TmNMV8eavD+/z3vQH+8kmQxT6qQBHBkPsr2fC4cZOhdg+ lku0cKSzxSQZSMbmKe6znewFLTL4ZMtX6CCAaYmvIczLedFFPbTLNcCI1G71qnodnw8EBpcFco sHhWMbNLTaCESCkLad4PfuZUGKiGngVM2rx1mqUKyg4+lA==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=herkefJLqjCXXLodZSSaxSAb3P2bDUz4SDuzvlZD0J0=; b=Ipz+AjmPcJiEYoEmxyQ1/Mtmlz T5P6MuBHG5QI9iJPqx40WXDOJhZZr87M6OgndPirk06vE4TFQA0UcpER5wOaaPpBEfWl7BkJuGmos d015NZLFriy8BtUFIADEj8z2RKK1cSHQ90B7bnDJgIh60Vzy07qCi3CzPDmf+6gUlRCip2DE0P6CT FIraDyJh7SuwONRbI8bPA5Q275J1FUwXTOCuuOYFezlsQ4j4b9oPLpUck6dJYUQqi0qF22RdJyVvw iYIxbUsgsSXhrPrKwJ1wUX5iN2Yz47szV6fsEQtG32SBULkE6T5FfVx5cHrUZu1X2b4kXO2GtD/l8 rFwoar1A==; Received: by zero.zsh.org with local id 1sByx9-0006yy-FW; Tue, 28 May 2024 15:41:31 +0000 Authentication-Results: zsh.org; iprev=pass (out-175.mta0.migadu.com) smtp.remote-ip=91.218.175.175; dkim=pass header.d=fugi.dev header.s=key1 header.a=rsa-sha256; dmarc=pass header.from=fugi.dev; arc=none Received: from out-175.mta0.migadu.com ([91.218.175.175]:62715) (DNSSEC AD) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_256_GCM_SHA384:256) id 1sByvz-0006e9-SL; Tue, 28 May 2024 15:40:22 +0000 X-Envelope-To: schaefer@brasslantern.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fugi.dev; s=key1; t=1716910817; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=herkefJLqjCXXLodZSSaxSAb3P2bDUz4SDuzvlZD0J0=; b=pGBEWdPcc4pZ1kqwdfwnpC4Bh7a9jf5EJ0MRs5z2Jxfz5s4mgi3YFGECYoNghWtHOr8mYn vLxx6SwOMFh1pTShIZXK50YDGZJ1AW+BElDzenCreX3c28Q9JfI7FUj6T5t6g2IZE0Z1Zh SQVDdFrnRaF5tZajenDenA5cD343yng= X-Envelope-To: zsh-workers@zsh.org X-Envelope-To: mikachu@gmail.com Message-ID: Date: Tue, 28 May 2024 17:40:11 +0200 MIME-Version: 1.0 Subject: Re: [PATCH] remote files completion: remove double-escaping Content-Language: en-US, de-DE To: Bart Schaefer Cc: zsh-workers@zsh.org, Mikael Magnusson References: X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Lyn Fugmann In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Seq: 52937 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: , List-Subscribe: , List-Unsubscribe: , List-Post: List-Owner: List-Archive: On 2024-04-12 20:59, Bart Schaefer wrote: > On Wed, Apr 10, 2024 at 11:45 AM Mikael Magnusson wrote: >> >> On Wed, Apr 10, 2024 at 12:47 PM Lyn Fugmann wrote: >>> >>> Removes the double escaping in the remote files completion. This affects rsync and scp. >>> For example, instead of a space character in a remote filename turning into `\\\ `, it will now correctly turn into `\ `. >>> While scp apparently works with either one, rsync requires the latter since version 3.2.4[1] (unless the legacy behavior is explicitly enabled). >>> This has been a problem for almost two years now. >> >> This should probably be behind a zstyle (I guess it's fine if it >> defaults to the new behavior), as currently this patch will break >> completion for older versions of scp and rsync. That way users can >> easily configure it per command or globally if they want. > > Doesn't this actually depend on the remote version rather than the > local command? Might need to be configurable based on the > destination? > > See also thread starting with workers/50484 from 2022 Subject: rsync completions I finally got around to testing this. The behavior appears to depend only on the local version of rsync, not on the remote version. Tested using local rsync 3.2.3 and 3.2.7, remote rsync 3.1.3 and 3.2.7. So I think the patch should be fine as is. (I would expect very few people to run an over two years old version of rsync and a recent version of zsh on the same local machine.)