* cvs completion problem in zsh-5.0.7
@ 2014-10-09 13:07 Bernard Cafarelli
2014-10-09 16:13 ` Bart Schaefer
0 siblings, 1 reply; 2+ messages in thread
From: Bernard Cafarelli @ 2014-10-09 13:07 UTC (permalink / raw)
To: zsh-workers
Hi,
after updating from zsh-5.0.6 to zsh-5.0.7, cvs completion does not work
anymore on my system (up-to-date Gentoo Linux~amd64)
With 5.0.7:
% cvs a<tab>
cvs command
ad adm ann
% cvs add new<tab>
unknown cvs command: add
While in 5.0.6:
% cvs a<tab>
cvs command
add -- add a new file/directory to the repository
admin -- administration front end for rcs
annotate -- show last revision where each line was modified
% cvs add new<tab>
completes correctly in:
% cvs add new-file.txt
I ran a git bisect and ended up with 5a2668a6ac1c:
33223: discard stderr except when _complete_debug is in progress.
Reverting it did get the old behaviour back. I have not seen any
other side-effects until I patched my system zsh
ps: I am not subscribed to the mailing list
--
Bernard Cafarelli (Voyageur)
Gentoo developer (NX, GNUstep, net-misc, llvm/clang, ...)
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: cvs completion problem in zsh-5.0.7
2014-10-09 13:07 cvs completion problem in zsh-5.0.7 Bernard Cafarelli
@ 2014-10-09 16:13 ` Bart Schaefer
0 siblings, 0 replies; 2+ messages in thread
From: Bart Schaefer @ 2014-10-09 16:13 UTC (permalink / raw)
To: Bernard Cafarelli, zsh-workers
On Oct 9, 3:07pm, Bernard Cafarelli wrote:
}
} % cvs add new<tab>
} unknown cvs command: add
}
} I ran a git bisect and ended up with 5a2668a6ac1c:
} 33223: discard stderr except when _complete_debug is in progress.
Well, dammit.
The assumption was that 2>&1 would have been passed down to _call_program
for the "eval" that it executes.
In actual practice in several cases it's the call to _call_program ITSELF
that has 2>&1 attached.
diff --git a/Completion/Base/Utility/_call_program b/Completion/Base/Utility/_call_program
index b657648..010e094 100644
--- a/Completion/Base/Utility/_call_program
+++ b/Completion/Base/Utility/_call_program
@@ -2,8 +2,8 @@
local tmp err_fd=-1
-if (( ${debug_fd:--1} > 2 ))
-then exec {err_fd}>&2 # debug_fd is saved stderr, 2 is log file
+if (( ${debug_fd:--1} > 2 )) || [[ ! -t 2 ]]
+then exec {err_fd}>&2 # debug_fd is saved stderr, 2 is trace or redirect
else exec {err_fd}>/dev/null
fi
--
Barton E. Schaefer
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-10-09 16:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-10-09 13:07 cvs completion problem in zsh-5.0.7 Bernard Cafarelli
2014-10-09 16:13 ` Bart Schaefer
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).