zsh-workers
 help / color / mirror / code / Atom feed
* [PATCH] Fix [:IDENT:] vs posixidentifiers
@ 2020-12-17 15:08 Stephane Chazelas
  2021-02-07 15:50 ` Stephane Chazelas
  0 siblings, 1 reply; 17+ messages in thread
From: Stephane Chazelas @ 2020-12-17 15:08 UTC (permalink / raw)
  To: Zsh hackers list

$ zsh -c '[[ é = [[:IDENT:]] ]]' || echo no
no
$ zsh -o posixidentifiers -c '[[ é = [[:IDENT:]] ]]' && echo yes
yes

That should be the other way round.


From: Stephane Chazelas <stephane@chazelas.org>
Date: Thu, 17 Dec 2020 14:49:50 +0000
Subject: [PATCH] Fix [:IDENT:] vs posixidentifiers

wcsitype(c, IIDENT) should return false for non-ASCII characters
when the POSIX_IDENTIFIERS option is on, not the other way round.
---
 Src/utils.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Src/utils.c b/Src/utils.c
index 5151b89a8..2a8d677a7 100644
--- a/Src/utils.c
+++ b/Src/utils.c
@@ -4327,7 +4327,7 @@ wcsitype(wchar_t c, int itype)
     } else {
 	switch (itype) {
 	case IIDENT:
-	    if (!isset(POSIXIDENTIFIERS))
+	    if (isset(POSIXIDENTIFIERS))
 		return 0;
 	    return iswalnum(c);
 
-- 
2.29.2


^ permalink raw reply	[flat|nested] 17+ messages in thread

end of thread, other threads:[~2021-05-18  0:38 UTC | newest]

Thread overview: 17+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-17 15:08 [PATCH] Fix [:IDENT:] vs posixidentifiers Stephane Chazelas
2021-02-07 15:50 ` Stephane Chazelas
2021-02-07 20:24   ` Bart Schaefer
2021-02-08  5:53     ` Daniel Shahaf
2021-02-08 20:51       ` Bart Schaefer
2021-02-09  9:11         ` Peter Stephenson
2021-03-22 17:17   ` Stephane Chazelas
2021-03-22 23:45     ` Lawrence Velázquez
2021-03-25  1:06       ` Daniel Shahaf
2021-03-28  1:48         ` Lawrence Velázquez
2021-03-29  6:30           ` Patch management workflow for threads that peter out (was: Re: [PATCH] Fix [:IDENT:] vs posixidentifiers) Daniel Shahaf
2021-03-29  6:35             ` Bart Schaefer
2021-03-29  7:26               ` Daniel Shahaf
2021-05-16 17:07                 ` Lawrence Velázquez
2021-05-16 18:24                   ` Bart Schaefer
2021-05-18  0:38                     ` Daniel Shahaf
2021-03-23  5:34     ` [PATCH] Fix [:IDENT:] vs posixidentifiers dana

Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).