From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 13242 invoked from network); 31 Mar 2022 22:45:28 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 31 Mar 2022 22:45:28 -0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Type:Subject:Cc:To:From:Date: References:In-Reply-To:Message-Id:Mime-Version:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=QTJ54Ay75tq4ixj+XFm/Xc3WYSduOjoMq25GHzJVidg=; b=eV4GoXLIWjynlSSxtDDuhZ3o0L r8vQoqbpEWeKCh4ZlO8b2xmCTYv8jOSehHMzhodlUCkn4ft1Ir7giAfVF/D7AkUG55rvEzjn+Iu8i u1kxqp7kTlRrsTYAsV8v1zqAK0/Gs1+9OKEpCNk8maX/5sm/jR+TZKTRU/Q7lp7zz8Z1vkJzYOX8O WlaoAFsdSe1hCFgM+GKgUD1m57vI6Q3BChUgc6DEagWBp2LzEjzRF69By0OiscYN5rs69DDF3aBwu F6ARMCvSwBG80QCjUEmHPDcVK8tTwxSOx2JjB/VU++98tEjrgTYn1dLQZMzpZC0YJ+bbUERzyvIqZ 2zdZ19AA==; Received: from authenticated user by zero.zsh.org with local id 1na3Xj-000CPL-NT; Thu, 31 Mar 2022 22:45:27 +0000 Received: from authenticated user by zero.zsh.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256) id 1na3XQ-000C4k-Vi; Thu, 31 Mar 2022 22:45:09 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailauth.nyi.internal (Postfix) with ESMTP id A5F2727C0054; Thu, 31 Mar 2022 18:45:07 -0400 (EDT) Received: from imap48 ([10.202.2.98]) by compute2.internal (MEProxy); Thu, 31 Mar 2022 18:45:07 -0400 X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudeihedgudefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefofgggkfgjfhffhffvufgtsehttd ertderreejnecuhfhrohhmpefnrgifrhgvnhgtvggpgggvlhojiihquhgviicuoehlrghr rhihvhesiihshhdrohhrgheqnecuggftrfgrthhtvghrnhepieekjeevledugeefiefgue elgffgtddtgeehvedvhedviefghedvffeuvddvueehnecuvehluhhsthgvrhfuihiivgep tdenucfrrghrrghmpehmrghilhhfrhhomheplhgrrhhrhihvodhmvghsmhhtphgruhhthh hpvghrshhonhgrlhhithihqdduudehudekjeejtdegqdduudelvdejfeekhedqlhgrrhhr hihvpeepiihshhdrohhrghesfhgrshhtmhgrihhlrdgtohhm X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id 5F47B21E006E; Thu, 31 Mar 2022 18:45:07 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.7.0-alpha0-382-g88b93171a9-fm-20220330.001-g88b93171 Mime-Version: 1.0 Message-Id: In-Reply-To: <20220228.222457.2128269761925169168.enometh@meer.net> References: <26439.1209238907@pws-pc> <1514882387.357077.1640002234148@mail2.virginmedia.com> <20220228.222457.2128269761925169168.enometh@meer.net> Date: Thu, 31 Mar 2022 18:44:46 -0400 From: =?UTF-8?Q?Lawrence_Vel=C3=A1zquez?= To: zsh-workers@zsh.org Cc: Madhu Subject: Re: PATCH: pattern incremental search Content-Type: text/plain X-Seq: 49948 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: On Mon, Feb 28, 2022, at 11:54 AM, Madhu wrote: > This doesn't fix the segfault: which just gets postponed. Besides > this breaks incremental-pattern-search, which just stops working and > doesn't match anything in the history. Also, the segfault only occurs > when zsh is built without multibyte. > > To hit the segfault, in a --disable-multibyte build > $ zsh -f > $ bindkey ^R history-incremental-pattern-search-backward > C-r . > > Please consider the attached patch which 1) reverts the above fix, and > 2) modifies the non-multibyte version of igetmatch to match the > multibyte version at some points. (Disclaimer. this is submitted with > no understanding of what the code does :) > > > Attachments: > * glob.c-fix-segfault-on-non-multibyte-history-inc.patch Was this fully obviated by workers/49870 (git 3bf95b9)? -- vq