From: "Daniel Shahaf" <d.s@daniel.shahaf.name>
To: "Shohei Yoshida" <syohex@gmail.com>
Cc: zsh-workers@zsh.org
Subject: Re: [PATCH 1/1] Update gnu make completion for version 4.4
Date: Sun, 22 Jan 2023 14:37:39 +0000 [thread overview]
Message-ID: <cd39a9ef-279a-4007-be3a-276d42a22714@app.fastmail.com> (raw)
In-Reply-To: <CAFX6MOOHCWg9qS5GmH4Kp4xyb4p_XgvdbyDT6zWExcFm+gZE=Q@mail.gmail.com>
Shohei Yoshida wrote on Fri, 20 Jan 2023 02:53 +00:00:
> On Thu, Jan 19, 2023 at 10:56 PM Daniel Shahaf <d.s@daniel.shahaf.name> wrote:
>> Shohei YOSHIDA wrote on Thu, Jan 19, 2023 at 10:57:24 +0900:
>> > +++ b/Completion/Unix/Command/_make
>> > @@ -165,6 +165,7 @@ _make() {
>> > then
>> > incl="(-|)include"
>> > option_specs=(
>> > + '(-b -m)'{-b,-m}'[ignored for compatibility]'
>>
>> Should we add an «!» to this optspec, so these two options aren't shown
>> in the output?
>
> Yes. I missed it, sorry. By the way, -b and -m options are ignored by
> gnu make and make no sense.
> So I removed it from the option list.
Sounds good to me.
>> > @@ -185,17 +187,18 @@ _make() {
>> > '(-p --print-data-base)'{-p,--print-data-base}'[print makes internal database]'
>>
>> Preëxisting issue: we should add the missing apostrophe.
>
> I fixed it.
Thanks a lot.
> Attachments:
> * 0001-Update-gnu-make-completion-for-version-4.4.patch
Pushed with a minor tweak (described the format of "seed" in the optarg
of --shuffle).
Thanks for the patch,
Daniel
prev parent reply other threads:[~2023-01-22 14:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-19 1:57 [PATCH 0/1] Update GNU " Shohei YOSHIDA
2023-01-19 1:57 ` [PATCH 1/1] Update gnu " Shohei YOSHIDA
2023-01-19 13:56 ` Daniel Shahaf
2023-01-20 2:53 ` Shohei Yoshida
2023-01-22 14:37 ` Daniel Shahaf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd39a9ef-279a-4007-be3a-276d42a22714@app.fastmail.com \
--to=d.s@daniel.shahaf.name \
--cc=syohex@gmail.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).