From: Stephane Chazelas <stephane_chazelas@yahoo.fr>
To: Peter Stephenson <p.w.stephenson@ntlworld.com>
Cc: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: PATCH: silence compiler
Date: Sat, 7 Nov 2009 19:42:33 +0000 [thread overview]
Message-ID: <chaz20091107194233.GA9435@seebyte.com> (raw)
In-Reply-To: <3378.1257542338@pws-pc>
2009-11-06 21:18:58 +0000, Peter Stephenson:
> Index: Src/Modules/attr.c
> ===================================================================
> RCS file: /cvsroot/zsh/zsh/Src/Modules/attr.c,v
> retrieving revision 1.5
> diff -u -r1.5 attr.c
> --- Src/Modules/attr.c 5 Nov 2009 09:44:32 -0000 1.5
> +++ Src/Modules/attr.c 6 Nov 2009 21:18:29 -0000
> @@ -42,7 +42,7 @@
> switch (symlink) {
> case 0:
> return getxattr(path, name, value, size);
> - case 1:
> + default:
> return lgetxattr(path, name, value, size);
> }
[...]
I don't know the context but why not if/else? or return (symlink
? lgetxattr... : getxattr... )?
Cheers,
Stephane
prev parent reply other threads:[~2009-11-07 19:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-06 21:18 Peter Stephenson
2009-11-07 19:42 ` Stephane Chazelas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=chaz20091107194233.GA9435@seebyte.com \
--to=stephane_chazelas@yahoo.fr \
--cc=p.w.stephenson@ntlworld.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).