From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-27363-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 26530 invoked by alias); 7 Nov 2009 19:49:24 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 27363
Received: (qmail 12308 invoked from network); 7 Nov 2009 19:49:21 -0000
X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,UNPARSEABLE_RELAY
	autolearn=ham version=3.2.5
Received-SPF: none (ns1.primenet.com.au: domain at yahoo.fr does not designate permitted sender hosts)
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
  s=s1024; d=yahoo.fr;
  h=Received:X-Yahoo-SMTP:X-YMail-OSG:X-Yahoo-Newman-Property:Date:From:To:Cc:Subject:Message-ID:Mail-Followup-To:References:MIME-Version:Content-Type:Content-Disposition:In-Reply-To:User-Agent;
  b=OkS8SuApU/kTm7K0CBb5q7LqKC5mhxHHGkFEVlFXn3SrftX6YdkzO+WqFGqsVichOAJGUTveGq50DB89EwigXotjx3rtHV8VknpM3kxLyxmOEQMSgnZeRa27IzjmkItkbJwIa/8zovAkEX45Gu74oNgB9qnoOv7pv8YrxTl3q/Y=  ;
X-Yahoo-SMTP: V1UR0WuswBDVD1eFhM33188Ir8ciBckz4W8ZMsAh
X-YMail-OSG: rxYK6TgVM1kVg72ajAqe5wdc4YBVRm55t6HK03IQ.RIo6TqWvB4VnccI0BgKVsI7c7SN8.Yp.v9KBO42H_dH_H6Sk3e.1OkA_GJWX5pF5SHv6gHbUrDpf6QkvSHY5HLo0djwpp.5nwqcQ_rt240e4UQC_kqYSFFvfzIOavytxwc42CUiVmUMjXAizur8DPuY2SHM5wmnGR4beMw1TDtdsoJUAyLN9Rssv9wAUMdct0qHyCgOt.YX3al_A3RnMtb.KdEBH_4LKyHg3m3parWuCLsMGYz.3Yjij7Y-
X-Yahoo-Newman-Property: ymail-3
Date: Sat, 7 Nov 2009 19:42:33 +0000
From: Stephane Chazelas <stephane_chazelas@yahoo.fr>
To: Peter Stephenson <p.w.stephenson@ntlworld.com>
Cc: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: PATCH: silence compiler
Message-ID: <chaz20091107194233.GA9435@seebyte.com>
Mail-Followup-To: Peter Stephenson <p.w.stephenson@ntlworld.com>,
	Zsh hackers list <zsh-workers@zsh.org>
References: <3378.1257542338@pws-pc>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <3378.1257542338@pws-pc>
User-Agent: Mutt/1.5.16 (2007-09-19)

2009-11-06 21:18:58 +0000, Peter Stephenson:
> Index: Src/Modules/attr.c
> ===================================================================
> RCS file: /cvsroot/zsh/zsh/Src/Modules/attr.c,v
> retrieving revision 1.5
> diff -u -r1.5 attr.c
> --- Src/Modules/attr.c	5 Nov 2009 09:44:32 -0000	1.5
> +++ Src/Modules/attr.c	6 Nov 2009 21:18:29 -0000
> @@ -42,7 +42,7 @@
>      switch (symlink) {
>      case 0:
>          return getxattr(path, name, value, size);
> -    case 1:
> +    default:
>          return lgetxattr(path, name, value, size);
>      }
[...]

I don't know the context but why not if/else? or return (symlink
? lgetxattr... : getxattr... )?

Cheers,
Stephane