zsh-workers
 help / color / mirror / code / Atom feed
From: "Marcus Müller" <marcus_zsh@hostalia.de>
To: Bart Schaefer <schaefer@brasslantern.com>
Cc: Philippe Troin <phil@fifi.org>, zsh-workers@zsh.org
Subject: Re: [Bug] modules zsh/tcp, zsh/zftp unloadable, probably affecting most modern Linuxes
Date: Wed, 7 Jun 2023 11:25:23 +0200	[thread overview]
Message-ID: <d4b5ab46-ad45-d4de-2a2b-2e18d67c4591@hostalia.de> (raw)
In-Reply-To: <CAH+w=7b3L+ZQ5P6xnxsJ-gG_Mx74jpn-UkTZt8P3ZYj1xc1bZg@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1492 bytes --]

Hey,

it looks like the Fedora crowd has decided that was a bug that surfaced already a while 
ago, which they then fixed, which then re-surfaced, as described in the newest comment on 
https://bugzilla.redhat.com/show_bug.cgi?id=2212160#c3 :

> This is the same bug as #1277996.
> It was fix by commit b5cac6b for zsh rpm by adding
> export LIBLDFLAGS='-z lazy'
> to zsh.spec.
>
> https://src.fedoraproject.org/rpms/zsh/c/b5cac6b431f08c03d2712fa9aac41b7cb43b9384
>
> But in recent Fedora '-z lazy' does not overwrite the '-Wl,-z,now'. It _seems_ we need to use '-Wl,-z,lazy'.
>
To summarize that #1277996 https://bugzilla.redhat.com/show_bug.cgi?id=1277996 , this 
*does* seem to actually be a bug:

https://www.zsh.org/mla/workers/2015/msg02981.html

Something must have reintroduced "now" instead of "lazy" linking in the module linking 
process.

Best,
Marcus

On 05.06.23 22:07, Bart Schaefer wrote:

> On Mon, Jun 5, 2023 at 12:35 PM Marcus Müller<marcus_zsh@hostalia.de>  wrote:
>> Ah, so we're exporting and thus overwriting a symbol that overwrites a
>> pointer by the name of an existing libc function with a "overrides
>> potentially unowned memory" one?
> As I understand it that symbol will only be defined by tcp.c if it's
> not available from libc or other linked library, so it's not actually
> overwriting an identically-named symbol.
>
> Or at least that's the intention, the #ifdef's that are meant to
> accomplish it may need refinement for more recent library changes.

[-- Attachment #2: Type: text/html, Size: 2713 bytes --]

  parent reply	other threads:[~2023-06-07  9:25 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-04 13:51 Marcus Müller
2023-06-04 20:37 ` Marcus Müller
2023-06-04 21:17   ` Philippe Troin
2023-06-05 19:35     ` Marcus Müller
2023-06-05 20:07       ` Bart Schaefer
2023-06-06  6:42         ` Jun T
2023-06-06  9:05           ` Peter Stephenson
2023-06-06 14:38             ` Jun. T
2023-06-06 15:01               ` Peter Stephenson
2023-06-06 16:37                 ` Philippe Troin
2023-06-06 17:54                   ` Mikael Magnusson
2023-06-07  2:05                     ` Jun T
2023-06-07  2:35                       ` Jun T
2023-06-07 14:40                         ` Jun. T
2023-06-23 13:41                           ` Jun. T
2023-06-07  9:25         ` Marcus Müller [this message]
2023-06-04 22:41   ` Axel Beckert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d4b5ab46-ad45-d4de-2a2b-2e18d67c4591@hostalia.de \
    --to=marcus_zsh@hostalia.de \
    --cc=phil@fifi.org \
    --cc=schaefer@brasslantern.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).