From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 21404 invoked from network); 12 Mar 2021 14:15:39 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 12 Mar 2021 14:15:39 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20200801; t=1615558539; b=fuoqkEK5DlOYbpZ3OjuD4uOGNfhYeSxPHdgtxCNNfxeAFIKSl7CK9XhokxqW5/4VE5cXBBn8fN 8PS3IXyzEa0uuZKY7mJlORDzB+NmdA8zptfG63vSZxy2ljKVRL0UmxZnjl+y2l4xLzkA+s4rAi yrDMf5s0dqM2b36DNmOuWMjRa8t4AvioZ/MzKD4G4rtDItlQt0FyssmNyJJolS+EIqN1T1HqPm vW6dsQr21rhvb1dIBcOnWL7lJ6drjyZAZ2l6q/CRalTb2lmJfL/6hs9n0v5F/4SGV0ectpc1Te sCdCM8fiOFFqwlPH3OdKDE7cR4eqYbecOlfr9DhCb+MuuA==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (wout5-smtp.messagingengine.com) smtp.remote-ip=64.147.123.21; dkim=pass header.d=daniel.shahaf.name header.s=fm2 header.a=rsa-sha256; dkim=pass header.d=messagingengine.com header.s=fm2 header.a=rsa-sha256; dmarc=none header.from=daniel.shahaf.name; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20200801; t=1615558539; bh=ncHolx0oOM4spg1GSQDmtjOEE2X6prix0T7iDJ4Uvzc=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Type:Subject:To:From:Date:References:In-Reply-To: Message-ID:MIME-Version:DKIM-Signature:DKIM-Signature:DKIM-Signature; b=dXOWoSsKhSdRWe2AARh5GHfgPylPAdh3SYydqBUC6ksTdo1fNQVZcWWpeSGHvHwL0rKamcfXJx jA1j+L6GrX6QRGtmglmvDtUbMLngrnBh5xOOy9PLPqsbJSvKbfwdws6GbxZv/uT3vuMdIX9kyo NIZ4Y1TsZdNcjItCrobL3hmf9atb8S3bQl1Ed/sFA2wNB9cIhtZh2jvwTMw8BGUM3uhipitTJx HRfLfDQmVHm72szRHlbAUfTy9j3qm01uW8UJ3US2O55K2kIHhlxXYiAfym3oF6UyttPtCeHl35 fOKG77/DgaWqrAz5UF0oiZKWfvX6IoGYBU+EyxUBn6kHPw==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20200801; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Type:Subject:To:From:Date: References:In-Reply-To:Message-Id:Mime-Version:Reply-To:Cc: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=h/YXVh6eEts2mSRJSjqRSztKPhd38FUG/WRNy2tG7ZA=; b=hd6SohNSPMMHOKh0l4UfWts4Qn 7fRekOZ8RRbHVYUNz95uSiXLpVXQThJlo1j6T7iRzD0NwpSi2RdO1BWG2uMNNDdbzGsDOwmILORzh EgaCk80Nuv43VG/y/w49suWIS7qcgVcqDBBP1DssQw58IiYlHXh2xL80hqc4mcFv3zPWYC/7gz6Zo gUMNIrcOoBrAslfFunEO6Yuik0fG15F4C3+8oqsUI91frHByUAJHv5Y2c2qkutY9sdupqnuQGpvyz aaAU1b5ewfMXsS0YXgN3RLhamJUNulRXeLIucryTAqO53jEGMYT0Tbaqwsp83K1FxmojSFqqcSl+5 mp9LsdXg==; Received: from authenticated user by zero.zsh.org with local id 1lKiZl-0001cv-KP; Fri, 12 Mar 2021 14:15:37 +0000 Authentication-Results: zsh.org; iprev=pass (wout5-smtp.messagingengine.com) smtp.remote-ip=64.147.123.21; dkim=pass header.d=daniel.shahaf.name header.s=fm2 header.a=rsa-sha256; dkim=pass header.d=messagingengine.com header.s=fm2 header.a=rsa-sha256; dmarc=none header.from=daniel.shahaf.name; arc=none Received: from wout5-smtp.messagingengine.com ([64.147.123.21]:36221) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_256_GCM_SHA384:256) id 1lKiZR-0001Tr-1D; Fri, 12 Mar 2021 14:15:18 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 237C81C30 for ; Fri, 12 Mar 2021 09:15:15 -0500 (EST) Received: from imap37 ([10.202.2.87]) by compute3.internal (MEProxy); Fri, 12 Mar 2021 09:15:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= daniel.shahaf.name; h=mime-version:message-id:in-reply-to :references:date:from:to:subject:content-type; s=fm2; bh=h/YXVh6 eEts2mSRJSjqRSztKPhd38FUG/WRNy2tG7ZA=; b=SDr8oRvKcpW3kegY4l6Iwgl D//d5vag2w249Atqny1GD6RBOUapID80+0iRvhdrEDjY4r0pn5EEcy5SXxIEPRWS UNlDkkPVH769hsMgWXdkSVRgyLLo1KI8uvgU9TTKHyA0w6i//8gzSznOJ5vag5f9 QG7kSY1QYwWuQy5bauJTQ11CvHn2ymEfikXqdhoclek0gJZyqXD8TSXq1GP6NT6o Q9ywDEgDocAi9/RGt8kK8UzSjuDzOkyx+RXHMqEETwTc1iPnv1Kpg6Jh0VtGhCOM Z6dvCNHOyqe9Sqs01gUX+axhlyAEmMZrq/VkfQ8qeyQGqRmVHykO6xlKAviMXzg= = DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=h/YXVh 6eEts2mSRJSjqRSztKPhd38FUG/WRNy2tG7ZA=; b=R181VEdLKzsGE2ZluUOBjl b9F3rQmUgpIjQiwl0K384yyoD9V9pBqfnbkP5EV6sc5CbR1cWZFfSfjj5D5NlhKP J6kBQw5FD22htzi4P3F9hrLAuGto3ek9IJDpONQGnlq2SXk1N3PbAV05GoUAsLnV yO3OHP74KML+rQ0dKd1qml4K3XYQoz8FRhD8x4DxlFD+LBth8XrcQ5A6x4q+tkgr ZqsazGbiHgynyCUhOMB98i3xqH41y/dQ/T651+Yk/Ro0MgTPhWxWgV1Ad18V0b/8 PSaU8kFwPX9j7AqlF+34Ox820ZKM2B/CQUBtHmXgXPiAyR+EVdl10s1xlcPlASIA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledruddvvddgiedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefofgggkfgjfhffhffvufgtsehttd ertderreejnecuhfhrohhmpedfffgrnhhivghlucfuhhgrhhgrfhdfuceougdrshesuggr nhhivghlrdhshhgrhhgrfhdrnhgrmhgvqeenucggtffrrghtthgvrhhnpedvheeitddvtd euveegteelvdfgieektdeuheegfefggeduffefkeeggffhueeuhfenucevlhhushhtvghr ufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegurdhssegurghnihgvlhdrsh hhrghhrghfrdhnrghmvg X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id 50CA86B40063; Fri, 12 Mar 2021 09:15:14 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.5.0-alpha0-206-g078a48fda5-fm-20210226.001-g078a48fd Mime-Version: 1.0 Message-Id: In-Reply-To: <1084110603.423549.1615556176994@mail2.virginmedia.com> References: <20210304201721.GA16874@tarpaulin.shahaf.local2> <20210307172246.GB9936@tarpaulin.shahaf.local2> <1084110603.423549.1615556176994@mail2.virginmedia.com> Date: Fri, 12 Mar 2021 14:14:12 +0000 From: "Daniel Shahaf" To: zsh-workers@zsh.org Subject: =?UTF-8?Q?Re:_Bug_+_patch:_`zstyle_':completion:*'_menu_select=3Dlong-li?= =?UTF-8?Q?st`_fails_to_start_menu_selection?= Content-Type: text/plain X-Seq: 48174 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: Archived-At: Peter Stephenson wrote on Fri, 12 Mar 2021 13:36 +00:00: > > > On 12 March 2021 at 13:11 Marlon Richert wrote: > > > > > > I found the culprit: I had > > > > export GREP_OPTIONS='--color=always' > > > > in my `.zshrc` file and that mangled the .mdd file names. > > It's probably worth having the following. It doesn't cover all the > possible cases where you can get into trouble, but it's a useful > blanket for the standard case where everything is done immediately > from configure. > I'm not sure I agree. - This seems to be a cases of "hard cases make bad law". Setting --color=always in the environment will break any script that expects grep(1)'s standard semantics, not just configure. The patch just papers over the problem. - We shouldn't second-guess the user. If the user has GREP_OPTIONS set in the environment, that might actually be needed in order to have grep(1) behave correctly. What if some system uses GREP_OPTIONS to make its grep(1) tool behave POSIX compatibly? - If this fix is needed, we should send it to autoconf upstream to be incorporated into AC_PROG_GREP. Instead, I propose: - Audit configure.ac and make sure we use $GREP rather than grep. Perhaps push this into the makefiles and build scripts too. - Consider issueing a notice if GREP_OPTIONS is set, or proposing to upstream to have AC_PROG_GREP do so. - Sending a documentation patch to grep(1)'s man page to point out that using --color=always globally or on the left hand side of a pipe is inadvisable. Makes sense? Cheers, Daniel > diff --git a/configure.ac b/configure.ac > index 16dafac05..41006d67d 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -30,6 +30,9 @@ AC_CONFIG_SRCDIR([Src/zsh.h]) > AC_PREREQ([2.69]) > AC_CONFIG_HEADER(config.h) > > +dnl Configure uses grep widely, make sure output is uncorrupted. > +unset GREP_OPTIONS > + > dnl What version of zsh are we building ? > . ${srcdir}/Config/version.mk > echo "configuring for zsh $VERSION" > >