zsh-workers
 help / color / mirror / code / Atom feed
* [PATCH] termcap.c: fix pointer type mismatch for boolcodes
@ 2024-09-25 16:15 liushuyu
  2024-09-25 16:30 ` Bart Schaefer
  0 siblings, 1 reply; 3+ messages in thread
From: liushuyu @ 2024-09-25 16:15 UTC (permalink / raw)
  To: zsh-workers; +Cc: liushuyu

This fixes build failure on GCC 14 and newer (where mismatching pointer
types are errors by default now)
---
 Src/Modules/termcap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Src/Modules/termcap.c b/Src/Modules/termcap.c
index af4009a3a..78ab999ee 100644
--- a/Src/Modules/termcap.c
+++ b/Src/Modules/termcap.c
@@ -42,7 +42,7 @@
 #ifdef HAVE_TGETENT
 
 #ifndef HAVE_BOOLCODES
-static char *boolcodes[] = {
+NCURSES_CONST char *const boolcodes[] = {
     "bw", "am", "ut", "cc", "xs", "YA", "YF", "YB", "xt", "xn", "eo",
     "gn", "hc", "HC", "km", "YC", "hs", "hl", "in", "YG", "da", "db",
     "mi", "ms", "nx", "xb", "NP", "ND", "NR", "os", "5i", "YD", "YE",
-- 
2.46.2



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] termcap.c: fix pointer type mismatch for boolcodes
  2024-09-25 16:15 [PATCH] termcap.c: fix pointer type mismatch for boolcodes liushuyu
@ 2024-09-25 16:30 ` Bart Schaefer
  2024-09-25 16:51   ` liushuyu
  0 siblings, 1 reply; 3+ messages in thread
From: Bart Schaefer @ 2024-09-25 16:30 UTC (permalink / raw)
  To: liushuyu; +Cc: zsh-workers

On Wed, Sep 25, 2024 at 9:17 AM liushuyu <liushuyu011@gmail.com> wrote:
>
> This fixes build failure on GCC 14 and newer (where mismatching pointer
> types are errors by default now)

Already fixed by commit 4c89849 (workers/52383) ?


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] termcap.c: fix pointer type mismatch for boolcodes
  2024-09-25 16:30 ` Bart Schaefer
@ 2024-09-25 16:51   ` liushuyu
  0 siblings, 0 replies; 3+ messages in thread
From: liushuyu @ 2024-09-25 16:51 UTC (permalink / raw)
  To: Bart Schaefer; +Cc: zsh-workers

> On Wed, Sep 25, 2024 at 9:17 AM liushuyu <liushuyu011@gmail.com> wrote:
>> This fixes build failure on GCC 14 and newer (where mismatching pointer
>> types are errors by default now)
> Already fixed by commit 4c89849 (workers/52383) ?

This patch is for when boolnames symbol does not exist in the system 
curses implementation.

I thought this patch might help match the symbol type defined in ncurses.

If you think this is not required, then I am fine with discarding this 
patch.


Thanks,

liushuyu



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-09-25 16:51 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-09-25 16:15 [PATCH] termcap.c: fix pointer type mismatch for boolcodes liushuyu
2024-09-25 16:30 ` Bart Schaefer
2024-09-25 16:51   ` liushuyu

Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).