zsh-workers
 help / color / mirror / code / Atom feed
* [PATCH] github #119: fix completion for git bisect visualize
@ 2024-08-12 18:11 Christian Heusel
  2024-08-14  2:39 ` Eric Cook
  0 siblings, 1 reply; 2+ messages in thread
From: Christian Heusel @ 2024-08-12 18:11 UTC (permalink / raw)
  To: zsh-workers; +Cc: Christian Heusel

When trying to use the completion for git bisect visualize one currently
is greeted with the curious error of something like this:

    git bisect visualize _git-bisect:89: command not found: arch

While in this case 'arch' is the name of the first folder in the
directory. The cause for this is a missing separation of switch cases
which we fix by inserting the needed ";;".

Signed-off-by: Christian Heusel <christian@heusel.eu>
---
This is a re-send of https://github.com/zsh-users/zsh/pull/119 which I
will close should this patch be accepted!

Thanks for your awesome work on zsh! <3
---
 Completion/Unix/Command/_git | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Completion/Unix/Command/_git b/Completion/Unix/Command/_git
index 22b945e38..6c6d59b24 100644
--- a/Completion/Unix/Command/_git
+++ b/Completion/Unix/Command/_git
@@ -278,6 +278,7 @@ _git-bisect () {
           _arguments -C -s \
             $log_options \
             $revision_options && ret=0
+          ;;
         (*)
           _nothing
           ;;
--
2.46.0



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] github #119: fix completion for git bisect visualize
  2024-08-12 18:11 [PATCH] github #119: fix completion for git bisect visualize Christian Heusel
@ 2024-08-14  2:39 ` Eric Cook
  0 siblings, 0 replies; 2+ messages in thread
From: Eric Cook @ 2024-08-14  2:39 UTC (permalink / raw)
  To: zsh-workers

On 8/12/24 2:11 PM, Christian Heusel wrote:
> ---
>   Completion/Unix/Command/_git | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/Completion/Unix/Command/_git b/Completion/Unix/Command/_git
> index 22b945e38..6c6d59b24 100644
> --- a/Completion/Unix/Command/_git
> +++ b/Completion/Unix/Command/_git
> @@ -278,6 +278,7 @@ _git-bisect () {
>             _arguments -C -s \
>               $log_options \
>               $revision_options && ret=0
> +          ;;
>           (*)
>             _nothing
>             ;;
> --
> 2.46.0

This has been committed, thank you!


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-08-14  2:39 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-08-12 18:11 [PATCH] github #119: fix completion for git bisect visualize Christian Heusel
2024-08-14  2:39 ` Eric Cook

Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).