From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-23880-mason-zsh=primenet.com.au@sunsite.dk>
Received: (qmail 1254 invoked from network); 1 Oct 2007 07:22:02 -0000
X-Spam-Checker-Version: SpamAssassin 3.2.3 (2007-08-08) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham
	version=3.2.3
Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88)
  by ns1.primenet.com.au with SMTP; 1 Oct 2007 07:22:02 -0000
Received-SPF: none (ns1.primenet.com.au: domain at sunsite.dk does not designate permitted sender hosts)
Received: (qmail 19288 invoked from network); 1 Oct 2007 07:21:55 -0000
Received: from sunsite.dk (130.225.247.90)
  by a.mx.sunsite.dk with SMTP; 1 Oct 2007 07:21:55 -0000
Received: (qmail 26084 invoked by alias); 1 Oct 2007 07:21:53 -0000
Mailing-List: contact zsh-workers-help@sunsite.dk; run by ezmlm
Precedence: bulk
X-No-Archive: yes
X-Seq: 23880
Received: (qmail 26064 invoked from network); 1 Oct 2007 07:21:52 -0000
Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88)
  by sunsite.dk with SMTP; 1 Oct 2007 07:21:52 -0000
Received: (qmail 18965 invoked from network); 1 Oct 2007 07:21:52 -0000
Received: from wx-out-0506.google.com (66.249.82.224)
  by a.mx.sunsite.dk with SMTP; 1 Oct 2007 07:21:47 -0000
Received: by wx-out-0506.google.com with SMTP id h27so3015983wxd
        for <zsh-workers@sunsite.dk>; Mon, 01 Oct 2007 00:21:46 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=beta;
        h=domainkey-signature:received:received:message-id:date:from:sender:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth;
        bh=k5DHs3f+hnLfijys/JnVtjgX7XP4MxtVc5VIIt+E9/8=;
        b=bCgrC2WqIo3qL3hkTvrW47pmxtb+5JQu/A8XJo2qPzFvFjAzca+aeoNEVoGhNU6AC85ljoxVDZj996n77nYy6reAz0VQkVHKKJ/I01EB+g6eZro0VhB7s9p8+KIj2r5Zgtb6a1z3utYz8L0nOaiy3FBTDEL8FMov5qWUfbDdjKk=
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=beta;
        h=received:message-id:date:from:sender:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth;
        b=R5dVYRgkZmIwgfCYdYVNTADn0OD9uerWlVeHUHA6tez/8e2hx09pTDZJZELD5MRUKjzrNY26uKVRHBP/354+QHR/Rsxq5xj/uMyZztDLGJ44RlPIIP5K3KOcvMMsttuDuqK9N1/ykxH3NVrNikGV5qLQytxsPnXaQYO1EJMcFbA=
Received: by 10.90.56.11 with SMTP id e11mr4765612aga.1191223305697;
        Mon, 01 Oct 2007 00:21:45 -0700 (PDT)
Received: by 10.90.93.19 with HTTP; Mon, 1 Oct 2007 00:21:45 -0700 (PDT)
Message-ID: <dbfc82860710010021v23bbb0fej3d093d58aebf3ee5@mail.gmail.com>
Date: Mon, 1 Oct 2007 09:21:45 +0200
From: "Nikolai Weibull" <now@bitwi.se>
Sender: nikolai.weibull@gmail.com
To: zsh-workers@sunsite.dk
Subject: Re: PATCH: _git and revision_arguments
In-Reply-To: <20070930191803.GA16961@scowler.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <20070930191803.GA16961@scowler.net>
X-Google-Sender-Auth: d4bedb1b2e97a6bf

On 9/30/07, Clint Adams <clint@zsh.org> wrote:
> This seems a slightly cleaner.

> +local -a revision_arguments

Ideally __git_setup_revision_arguments would take an argument that
told it what variable to use.  Making it harder to instigate such a
change doesn't make the code any cleaner.  Also, this change wastes
memory, as revision_arguments will always be in scope, while not
saving any (real) execution time.

  nikolai