From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 24330 invoked from network); 7 May 2022 04:25:01 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 7 May 2022 04:25:01 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1651897502; b=HWtBSPhJ836ymeZ5L9K1PpEwUCKKTvWmtvFQOpi+XnXgC7Q6dn87tlWwMBEkP0258WaCa2XTWH mwahtkplBgqwXQ89YWNBakZQHadDQg/tz1CGWoZJd3mN2ux96P+L9AjErHKAauxfPsf5VExUzi /Njroqn9uVj9jkGdNZss4BtzHRTF6/tCzzl9wziM4T5UFUZ3pIigrAKU5EMHqmpWcMsN4ZMd+K QW8n9cOf1wmzhiOCmhKnESvAP86V8NaKEV16uPDTZvCgBgR+qbitTIrhD/ky1wV5yTxTQcBTg7 Rwo+1yiBRzIUhbEilQTW9FLXtJ84dUNQ8QstY33r99llOQ==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (wout4-smtp.messagingengine.com) smtp.remote-ip=64.147.123.20; dkim=pass header.d=dana.is header.s=fm1 header.a=rsa-sha256; dkim=pass header.d=messagingengine.com header.s=fm1 header.a=rsa-sha256; dmarc=none header.from=dana.is; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1651897502; bh=AK+wtpctTObdCEcFLmBlPTCYTyxnjUWcnTH28Z220Ko=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Type:Subject:Cc:To:From:Date:References:In-Reply-To: Message-ID:MIME-Version:DKIM-Signature:DKIM-Signature:DKIM-Signature; b=FudkALFxU1GDsN3Eh/o58d1XO69X3QYqgiSIYa+quw9Oh0N572RWsuUhvV8sD0L0NzQdNyVoEw giSUhQcQf9lw5jw0L7bnQ8XmfksblR6B50UlRNuUsqYLMfHtApXa36X7F4l6IXWjPj1vScPgzn xoXU2BxrPyk1vsezr7T0JL07+WexAF4mirzqZ0VQf6qaBIQB9Ap+4DpJTBg3l+mo/9gyoMgj7n c+Pz8JklPPfSrd1bs1u7qWBY2tST2i6LADcmOLQTFDhVTDZbte/td87xnhvdA75VpW+lGXnmx1 2mp+vm47uZhsLWne5gUvZOdbSFKUBth3myUdNxAYXTjjFQ==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Type:Subject:Cc:To:From:Date: References:In-Reply-To:Message-Id:Mime-Version:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=wmTx3w45C1p8PzOsN5p3A9CEqsDh9/02LBV8RgPzKHo=; b=VQVKS8oGzZGXeuq2odvP6kszPT I3YNt6Emp0riL1ZA43NTuuWuHa8QUvqpqQn5cNg32dyfCwMLFhd2evbwjN/IcP0MqM7+jlz/IwzKk yLSgQg2p37VMszyqZiKZKVyQg+LlTOXGUOy0uFv97rMKv+J4+qHdvTr/09bB7xkcEY7ThY+emLGy5 TuWXrlQT3vYAnsMQuXvViL/PTa/Y3fhvWldjjVKpUhtRlwqV2cY5k+qvN0gnt2bgv8/72D+CrE0mE b2ct7RIxqt7FWYCtLLpUv9/XWcHszavAYxqyfu/QglTsFyDyLYjxMGCsQuK8yMkNsoJqMmcf1JYio w2uOrWtQ==; Received: from authenticated user by zero.zsh.org with local id 1nnC05-0008Gk-Oh; Sat, 07 May 2022 04:25:01 +0000 Authentication-Results: zsh.org; iprev=pass (wout4-smtp.messagingengine.com) smtp.remote-ip=64.147.123.20; dkim=pass header.d=dana.is header.s=fm1 header.a=rsa-sha256; dkim=pass header.d=messagingengine.com header.s=fm1 header.a=rsa-sha256; dmarc=none header.from=dana.is; arc=none Received: from wout4-smtp.messagingengine.com ([64.147.123.20]:38709) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_256_GCM_SHA384:256) id 1nnBzs-0007wq-TO; Sat, 07 May 2022 04:24:49 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 3C2F7320090A; Sat, 7 May 2022 00:24:47 -0400 (EDT) Received: from imap50 ([10.202.2.100]) by compute5.internal (MEProxy); Sat, 07 May 2022 00:24:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dana.is; h=cc:cc :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1651897486; x=1651983886; bh=wmTx3w45C1 p8PzOsN5p3A9CEqsDh9/02LBV8RgPzKHo=; b=x9+z5W8nPN3ydltl66xFTHPvV6 CT8Khqis5+S2gcNeFILvOIxjKgI5jq/f0Vadwi/8sZLHoFZJzRwxKx3ZI3hIeeh8 +juEGOsph2AMSAVyHVhMUDUdWJxRvwGNgIumFTg/TgGWReuV92y0CXA/LjqdwBlZ rO8y0B94kABDBQ4s5BxFnkGqEaZMpfBIDLNYLx8ZXfP+j5ItvZ7ntMKsonLB4r0A x7w1yi4kUlgBfYh973nOvvt1e6bOF2ZExj6SsDDsy8LLvGmJKiMAySleATzb6Wny j67XuESOxCbTr4Kjdvm03OeVjRDUdZbZJ10jXdhegRtY26NzB4u9rwhZqtIA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1651897486; x= 1651983886; bh=wmTx3w45C1p8PzOsN5p3A9CEqsDh9/02LBV8RgPzKHo=; b=W CxFcroaqv3IARl//a1AUsX16WGnKDq7aefc45ZCkb0ssi7qYpeJXbHG/OBoowTto Ni1gogY+uemN1FFc7Lj61xnWPl/PgJsRb7qZRindrd/HKtE4SMZSMaanUJk++DNt tNpX8en+wW3fZyfJjUVpqGv81nIUKb7vgD8ioq8JokQPvwmb7vMK7Y/FSDbGOb76 g1RKXlaeOUzTa4wkQI452mTTBPyGbTYym321PCYjGr8bEw3KciA5CpgAuC+CiEZu HFc22k72WA9kzPTg4w6TBmSrSS+EtrrLowflJNLc6Q10zZuhr/zUtdUpw3+nGtdr A/VBzyUcZlXK2MQRUnweg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeeggdejlecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefofgggkfgjfhffhffvvefutgesthdtredtreertdenucfhrhhomhepuggrnhgr uceouggrnhgrsegurghnrgdrihhsqeenucggtffrrghtthgvrhhnpefggfeifeetueeutd eitddttdfggedtleevjeelgfekteekhfekgfdtgeefueelueenucevlhhushhtvghrufhi iigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegurghnrgesuggrnhgrrdhish X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id 830E5170005C; Sat, 7 May 2022 00:24:46 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.7.0-alpha0-591-gfe6c3a2700-fm-20220427.001-gfe6c3a27 Mime-Version: 1.0 Message-Id: In-Reply-To: References: Date: Fri, 06 May 2022 23:24:25 -0500 From: dana To: "Bart Schaefer" , "Zsh hackers list" Cc: "Marlon Richert" Subject: Re: [PATCH][RFC] Improve completion of Gradle tasks Content-Type: text/plain X-Seq: 50181 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: On Fri 6 May 2022, at 21:57, Bart Schaefer wrote: > Any objections to this sneaking into 5.9, despite .3-test already spun? I don't know anything about Gradle, so i'm not sure if the way it handles task completion is desirable. But i didn't see anything obviously wrong with the patch, and it's not a critical component, so i don't object in principle I did note these pre-existing issues which might be fixed in a future revision: * _gradle_caching_policy is redefined every time the function executes * possibly _arguments should have -s and/or -S? * several of the options seem to be missing exclusion information * none of the option descriptions use the conventional capitalisation, punctuation, or mood for completion functions * there seems to be some confusion over whether short options that take arguments need + in the spec, and possibly the long options need = * completion for -x just fails silently if there's no build file dana