From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 27151 invoked from network); 8 Feb 2021 07:56:45 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 8 Feb 2021 07:56:45 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20200801; t=1612771005; b=0rhF6sGNE/NytPXyDqLmXAldvitRTGhpJb2y0xjmkyC7FFjD2FxX3tcLFso1M7jGIfTkJWHWv7 MYbEJstZIVjZSHVI1hXzgsUDXO+r523avFx69Qtl7shm5uvpkD3B2VZIDmKbLX6k1zNYJ/Qp/e lSPCvRdIu0q/Q5M9ui2e4CIImbYToWkb3r3tEJ9l431c3eIveNZZ9hyaqF7uXxudKNpfMQZQuU b4/xpAjjaVTqs4Ko9kUmIwELQs6P49RPunoYcqXJC/eCQymFswpGVpDi67Yu2yx8rfdS5eK6G2 TNidNL8TEdbFp3BVFOL1X2T/RGFHDrgs/F5rF4GRISdyKQ==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (out2-smtp.messagingengine.com) smtp.remote-ip=66.111.4.26; dkim=pass header.d=daniel.shahaf.name header.s=fm2 header.a=rsa-sha256; dkim=pass header.d=messagingengine.com header.s=fm2 header.a=rsa-sha256; dmarc=none header.from=daniel.shahaf.name; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20200801; t=1612771005; bh=XCPGnAazVHniNnc7ZNJCqWI8foUo5U633iUBwswgU/U=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Type:Subject:To:From:Date:References:In-Reply-To: Message-ID:MIME-Version:DKIM-Signature:DKIM-Signature:DKIM-Signature; b=enZgRbTX66EYNGvnjJAI6PWj4hh1JKqyBrRC4byKOhr0HcJgtMR2KmeCFN7MYgR9KlgimPDvRl 3eTQaQUijizIpmC/b/zV6kr6Sseb3qlZASVNVvH0g98/aZhxjZ8mSoLDTaUKKGV/PmoJn+ZlRh qyk9fnUJkpk3td8oH67ZTRXOwiKehy+vTHLk5DAKrgygbqZO9cuHJPtbXfHtqDAU3wXS+1cV30 JUq7tDBs13D82OeG1LXTAV7oWWn5dJfjcaZNLd+GUPhppYWxs5vsFcZd5qKuuGMCpSTQZV2z9m Te18D8zpx4nUURPEOfw0tT5VOGxiteyRgwsi9lUrluAT2w==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20200801; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Type:Subject:To:From:Date: References:In-Reply-To:Message-Id:Mime-Version:Reply-To:Cc: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=C+oSZanUiAr+FbVoDwvIqBFNZtgvFVrcBrS7wQNie2c=; b=BkjsImUyqO3Pw3o+qFfwNo+h7o RA1D16ldxffiTz5vbaqQ8iR62gYPybhhmfPaJY45Ftnkorg9OxsTDcAZm7+1DZ84RgtHO700jbYAu h8yhhhzv0s+Qx/lhoraqx4yg6DOSW7Gh+cJtFikWwpocBUeXImEGmT2Iia2DQ4DOwy6jn/bmam2eD fgC83iYxZTAwn3M0McJ0KgUdZUc8mSflbqd4AYWuxpC2KJZt/mo5fmauxrKjCNekWKBLxyuFQ8KPC 4RoCh3oKmDpo8RN5/yzXA4CNVFbS/VJYhz/zeVFGlQgPqcLW61/+cD67uL+qsayLVe1L9vod/MZW8 3Psf/pIg==; Received: from authenticated user by zero.zsh.org with local id 1l91PW-0007p7-Ok; Mon, 08 Feb 2021 07:56:42 +0000 Authentication-Results: zsh.org; iprev=pass (out2-smtp.messagingengine.com) smtp.remote-ip=66.111.4.26; dkim=pass header.d=daniel.shahaf.name header.s=fm2 header.a=rsa-sha256; dkim=pass header.d=messagingengine.com header.s=fm2 header.a=rsa-sha256; dmarc=none header.from=daniel.shahaf.name; arc=none Received: from out2-smtp.messagingengine.com ([66.111.4.26]:58097) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_256_GCM_SHA384:256) id 1l91PF-0007gi-8T; Mon, 08 Feb 2021 07:56:27 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 218955C0139 for ; Mon, 8 Feb 2021 02:56:07 -0500 (EST) Received: from imap37 ([10.202.2.87]) by compute3.internal (MEProxy); Mon, 08 Feb 2021 02:56:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= daniel.shahaf.name; h=mime-version:message-id:in-reply-to :references:date:from:to:subject:content-type; s=fm2; bh=C+oSZan UiAr+FbVoDwvIqBFNZtgvFVrcBrS7wQNie2c=; b=U7FrDgldt7OvHELuBi65fLj HUXZg5eLv0zEktxKBHax3ePBPB3GFuUCjLUN0EM35fA/YMxMotOdMkmFHlI1JAyC Si+P7dPc0HCdxy2nADWhzrVtw37uaaOz+dlCx+6qzrhNcUgQg3wEa7urx8LngudR 8fErEullqJaq836Re/0n3YNsdcoDAuzsCCUU00fNxKH+BHtz+LucTFQjfrvNUmyG BhpUzM9Yq2m/DVCqx9U6QHwOsFq6OSfNPziWQxLkr2yrGtbRQEkUM4T27Bo2yPE4 QWdjPGbFGVPHJ354dYSnlAoxL5nrvz7iOYs5OES7s1zdxOdFdX+89U+aYgr77Kw= = DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=C+oSZa nUiAr+FbVoDwvIqBFNZtgvFVrcBrS7wQNie2c=; b=L4Xvl97aImAGeySuNLbRcp bgTnsM0215tzu2WqjTcINENwvVnqXEVX6xTfh4e05sOTrt0RMksMXCZ9Xt9OI/Nk sd92Ab/013cuyP9TcLsShsCf9CK8WlWZqqr/L3HG+vzlWBTOsKBlyvFKpWqaoq/J c9JFQVEFjoTNeAEa2FXXZbMWBXwidWO7uqdBS272hAXGXDuBJkUuyPSMYO+VMus/ FKpQKob6wfZm2+RaDYKazHs+JuqmJMffpqe5+Ttjjr6g3TJuSGiPntwyisteoDcA p8hIhLdLxq9Zn73v3VYagHIiYH/PG+oNPck0bREaG9y598SVchLqvrIKHvRaHBKw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrhedvgdduudefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefofgggkfgjfhffhffvufgtsehttd ertderredtnecuhfhrohhmpedfffgrnhhivghlucfuhhgrhhgrfhdfuceougdrshesuggr nhhivghlrdhshhgrhhgrfhdrnhgrmhgvqeenucggtffrrghtthgvrhhnpeejueevheeuke ejtdffgeevlefhteehhfelhfffgfduuefhtddvhefhjeekgeehtdenucevlhhushhtvghr ufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegurdhssegurghnihgvlhdrsh hhrghhrghfrdhnrghmvg X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id 95BB56B4005F; Mon, 8 Feb 2021 02:56:06 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.5.0-alpha0-93-gef6c4048e6-fm-20210128.002-gef6c4048 Mime-Version: 1.0 Message-Id: In-Reply-To: <27939-1612662514.721483@P16v.HIcB.BuEO> References: <27939-1612662514.721483@P16v.HIcB.BuEO> Date: Mon, 08 Feb 2021 07:55:15 +0000 From: "Daniel Shahaf" To: zsh-workers@zsh.org Subject: Re: PATCH: update completions for procps 3.3.16 Content-Type: text/plain X-Seq: 47947 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: Archived-At: Oliver Kiddle wrote on Sun, 07 Feb 2021 01:48 +00:00: > I'm not keen on tracking these versions in comments in the completion > files themself because updating the comment everytime there's a new > release that doesn't add options would get silly. I don't see the problem. If you review procps 3.3.17 and find that it _doesn't_ add new options, that'd be useful information to share with other maintainers of the procps completion, so as to avoid duplication of work. Right there at the top of the file seems like the best place for the version number datum, because that way there is no atomicity problem when updating the completion. Recording that datum in the log message, as this patch does, means there's no way to update the datum without making a dummy change to the file (Git's data model can't represent "Commit X touched ./foo but didn't change it"). The usual argument against churn is that any change risks causing a regression or disrupting future git-blame(1) or git-bisect(1) work. These concerns don't seem to apply to version number comments. All that said, you're doing the work so it's your decision. Cheers, Daniel