zsh-workers
 help / color / mirror / code / Atom feed
From: WGH <wgh@torlan.ru>
To: Daniel Shahaf <d.s@daniel.shahaf.name>
Cc: zsh-workers@zsh.org
Subject: Re: [PATCH] _git: Fix __git_recent_branches for case when commit has empty message
Date: Sun, 2 Feb 2020 02:50:08 +0300	[thread overview]
Message-ID: <e504f0b9-32aa-3125-d31e-cbc0c6c0039c@torlan.ru> (raw)
In-Reply-To: <20200201000919.32cba94b@tarpaulin.shahaf.local2>

On 2/1/20 3:09 AM, Daniel Shahaf wrote:
> Not on my machine.
>
> First, the unidiff was improperly serialized: the spaces at the start
> of each context line were converted to non-breaking spaces (U+00A0).

Oh, damn, despite all my efforts, Thunderbird still messed the patch up. Sigh. (gotta finally find some sane mail client)

Anyway, copypasting it from the mailing list archive results in something that applies cleanly: https://www.zsh.org/mla/workers/2020/msg00190.html

> I applied the patch manually, and completion did work, but stderr was
> spammed with two warnings:
>
> +__git_recent_branches:21>   local $'z=\C-@'
> __git_recent_branches:21: command not found:

That isn't supposed to happen. This should merely assign a string contained a single null byte to variable z. Maybe you didn't clean up all those NBSP?

>  
> +__git_recent_branches:22> _call_program all-descriptions 'git --no-pager for-each-ref --format='\''%(refname)%00%(subject)'\' refs/heads/master --                                                                
> __git_recent_branches:22: unknown file attribute:

Likewise, I have no clue what it is.




  reply	other threads:[~2020-02-01 23:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-31 16:57 WGH
2020-02-01  0:09 ` Daniel Shahaf
2020-02-01 23:50   ` WGH [this message]
2020-02-02  7:34     ` Daniel Shahaf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e504f0b9-32aa-3125-d31e-cbc0c6c0039c@torlan.ru \
    --to=wgh@torlan.ru \
    --cc=d.s@daniel.shahaf.name \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).