From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2]) by inbox.vuxu.org (OpenSMTPD) with ESMTP id 8e1aa5f7 for ; Sat, 1 Feb 2020 23:51:00 +0000 (UTC) Received: (qmail 5185 invoked by alias); 1 Feb 2020 23:50:52 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 45374 Received: (qmail 5979 invoked by uid 1010); 1 Feb 2020 23:50:52 -0000 X-Qmail-Scanner-Diagnostics: from forward100p.mail.yandex.net by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.102.1/25703. spamassassin: 3.4.2. Clear:RC:0(77.88.28.100):SA:0(-2.6/5.0):. Processed in 3.057519 secs); 01 Feb 2020 23:50:52 -0000 X-Envelope-From: wgh@torlan.ru X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at _spf-ipv4.yandex.ru designates 77.88.28.100 as permitted sender) Subject: Re: [PATCH] _git: Fix __git_recent_branches for case when commit has empty message To: Daniel Shahaf Cc: zsh-workers@zsh.org References: <5391aaa5-73e7-266c-adb2-8c7d96373b8e@torlan.ru> <20200201000919.32cba94b@tarpaulin.shahaf.local2> From: WGH Message-ID: Date: Sun, 2 Feb 2020 02:50:08 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.2 MIME-Version: 1.0 In-Reply-To: <20200201000919.32cba94b@tarpaulin.shahaf.local2> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US On 2/1/20 3:09 AM, Daniel Shahaf wrote: > Not on my machine. > > First, the unidiff was improperly serialized: the spaces at the start > of each context line were converted to non-breaking spaces (U+00A0). Oh, damn, despite all my efforts, Thunderbird still messed the patch up. Sigh. (gotta finally find some sane mail client) Anyway, copypasting it from the mailing list archive results in something that applies cleanly: https://www.zsh.org/mla/workers/2020/msg00190.html > I applied the patch manually, and completion did work, but stderr was > spammed with two warnings: > > +__git_recent_branches:21>   local $'z=\C-@' > __git_recent_branches:21: command not found: That isn't supposed to happen. This should merely assign a string contained a single null byte to variable z. Maybe you didn't clean up all those NBSP? >   > +__git_recent_branches:22> _call_program all-descriptions 'git --no-pager for-each-ref --format='\''%(refname)%00%(subject)'\' refs/heads/master --                                                                 > __git_recent_branches:22: unknown file attribute: Likewise, I have no clue what it is.