From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A,RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 5195 invoked from network); 24 Oct 2022 02:57:12 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 24 Oct 2022 02:57:12 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1666580232; b=DYECtlmD7AlPVgCHg4JmgloLlrk6hmAZd3eofMfUsxlXFPgsHyAVppZTGrjDiJpJorUD/8zxYc T+UxDbqjLIH5gArBFE2PbxTm4FM8lfYWpErJwX9JUH/ZQ8ugtHwT95PV3B+zy1CCyPDAoHN1et yBUFrws5P31ig4CMSo/e95Jk5R5ncGQvgc3k4QPX9oecRabB9sCPrcvvD5ZjvjDWu7DA5IeBRv tgLLcWinmqK4p+EOYjIf9qDZ+YI97cg8F2HZy4JLxfEVcsZN8WkuWXeg/ltIBkHELvUW8/2QC/ kukZGxUlqyMKEo5fFmaKcHe76SmXfFeiGugeOs7wnvzdEw==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (iris.zentaur.org) smtp.remote-ip=198.58.127.206; dkim=pass header.d=zentaur.org header.s=dkim20200120 header.a=rsa-sha256; dmarc=pass header.from=zentaur.org; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1666580232; bh=26vSnU+BVlC2/gRJeBrbStuzvpSWk+LyNMLERBUGfZY=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:To:Subject:MIME-Version:Date:Message-ID:DKIM-Signature: DKIM-Signature; b=REul5jD9Wk0W5YM36mRgPY9qm/LZagfR6RqWwFUwyJI2rIL75dkitXKXJS41LEcEhCS3nsxNIp 1lLwc+jOiA8Cwg65/adFjv7DB6wgVYmaiaeolzJe5fRC4fM1rJEwZMLRkT/uh3xGnAwj2AjEdV Hd+4eOKqeBEcWy76lVyh0i4d47fzZlT/L3eb6fH/5+beXst6gIuSsWHPIQwUnCh9x2+76WzbwB OgrceyIsVQlTAfJGxQkR7aV/w1D5hf/aBJQFvivITxZ7AgQCgWws0Tu7Ksmg5xkhNcy21bR63e Yh36swqa9Az4UyxoiOnZpo57YKZvzQZj+rK8NuzMJ+V2yw==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From :Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=utV8FvqjRL7thwwwZzNIDm9AjJtsjqS0yF6lOCbkD9k=; b=lpsEfJUJanyKmZrDPVzZ8OA4Ow gf2xhgY6kUN0cZoBN6UMUKMxTVVmWGjIiGOFmOfFuYemnu9iW82BnjtonIef6bhw9GYZ0qkI9mAdv 7BJdzQ63fADOtsALHw9zO+1OtDyiocn/OSaiv1ZUz/RwnEA6huzApiGzUVzA6ZHhbcCwxG6qR759U Es/uswIa3ajcGWJ44GEsG7kz2e/Mrksqbc823+u3oIEkbC6IMvhn1hRNN5YCb4Za2avQKg8TupLqO EwwnsvlclzgbwTTtgf2mP8JGp0sqHqmLbvdMEhHmjSrRsJJeXO8oN+fD+Potsmjb51z3V/+uOUQSm GZZcEcxQ==; Received: by zero.zsh.org with local id 1omneJ-0007DW-96; Mon, 24 Oct 2022 02:57:11 +0000 Authentication-Results: zsh.org; iprev=pass (iris.zentaur.org) smtp.remote-ip=198.58.127.206; dkim=pass header.d=zentaur.org header.s=dkim20200120 header.a=rsa-sha256; dmarc=pass header.from=zentaur.org; arc=none Received: from iris.zentaur.org ([198.58.127.206]:46478) by zero.zsh.org with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) id 1omndf-0006rG-FR; Mon, 24 Oct 2022 02:56:33 +0000 Received: from iris.zentaur.org (localhost [127.0.0.1]) by iris.zentaur.org (Postfix) with ESMTP id 4Mwfq21cPKz3wZj for ; Mon, 24 Oct 2022 02:56:30 +0000 (UTC) Authentication-Results: iris.zentaur.org (amavisd-new); dkim=pass (2048-bit key) reason="pass (just generated, assumed good)" header.d=zentaur.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=zentaur.org; h= content-transfer-encoding:content-type:content-type:in-reply-to :from:from:references:to:content-language:subject:subject :user-agent:mime-version:date:date:message-id; s=dkim20200120; t=1666580189; x=1666583790; bh=26vSnU+BVlC2/gRJeBrbStuzvpSWk+Ly NMLERBUGfZY=; b=rXCRdJh6+eS+4jqbNU8M/YrAT9C5FzLG+ssQF0aExZbILFs/ 7cb0q1BuyKaG4f74fHP1JfbBh2vUZK4v7/5E1obDZ2B5/dEJSD+IXam+XRkneO1I hu0vgp10jB9EjDrWWVFtCFZdCgiH8ifLgNv67cYlS8/UPEyZqGpR+FBhhIvOloeQ 2Y5jzzc237IX3AE87iP1l1CftoRzQX+Jq1dPs8sCpGghdChuAEJ7mFv81a5CSZPa Hm7BZtPzDrr6Ak/rs4/Ftx3eUS355juuxn8poxFUL80/KOpN5RL7/sSgV+uxjfT7 JHScftN98ZTyvCscPdKRFuQ8jGBaUoWyLKbmvw== X-Virus-Scanned: amavisd-new at iris.zentaur.org Received: from iris.zentaur.org ([127.0.0.1]) by iris.zentaur.org (iris.zentaur.org [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 58dyxSlPGcBt for ; Mon, 24 Oct 2022 02:56:29 +0000 (UTC) Received: from [192.168.72.136] (unknown [136.50.213.220]) by iris.zentaur.org (Postfix) with ESMTPSA id 4Mwfq147Vkz3wZb for ; Mon, 24 Oct 2022 02:56:29 +0000 (UTC) Message-ID: Date: Sun, 23 Oct 2022 21:56:19 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.3 Subject: Re: preliminary patch for zsh/random module Content-Language: en-US To: zsh-workers@zsh.org References: From: Clinton Bunch In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed X-Antivirus: Avast (VPS 221023-6, 10/23/2022), Outbound message X-Antivirus-Status: Clean Content-Transfer-Encoding: quoted-printable X-Seq: 50829 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: , List-Subscribe: , List-Unsubscribe: , List-Post: List-Owner: List-Archive: On 10/23/2022 9:01 PM, Bart Schaefer wrote: > On Sat, Oct 22, 2022 at 8:44 PM Clinton Bunch wro= te: >> It still needs testing on more platforms and additional error-checking >> as well as documentation, but I was hoping for some feedback on the >> general ideas. > Silly nits: > * Typo in the introductory comment. I'm pretty sure I've since found and changed all the instances of=20 Zoltan's name. > * Indentation is funny, it looks like you may have used tab width > other than 8 characters, which is the standard for zsh C code. (Or > just never use tabs to indent.) Blame notepad.=C2=A0 Thunderbird doesn't allow me to attach inline, so I = had=20 to open in Notepad and cut-n-paste.=C2=A0 I didn't notice until after I s= ent=20 it, how bad the indentation got messed up. > * There should be spaces on either side of assignment "=3D" signs. You > haven't been consistent. I think I fixed all those.=C2=A0 I haven't been consistent because it see= ms=20 unnatural to me.=C2=A0 Waste of line width. > > Aside to -workers: It's probably time to remove Zoltan's name from > the copyright notices ... or more likely, to specify that the authors > of new files should replace his name with their own name there. > > Actual question: What's the use case for returning or printing a > block of random bytes? Why does this need to be a builtin? Mostly because I see constructs like read -k6 -u3 3 > Suggestion: Treat SRANDOM like SECONDS, in that you can change the > type from integer to floating-point. Then maybe the zrandom() math > function isn't needed? That would seem confusing to me, and too easy to forget which state you=20 left it in. zrandom was meant to be a replacement for rand48 >