From: Sebastian Gniazdowski <psprint@zdharma.org>
To: zsh-workers@zsh.org
Subject: Re: A patch with hashtable optimization, which doesn't work
Date: Thu, 18 May 2017 14:16:45 +0200 [thread overview]
Message-ID: <etPan.591d90ad.1190cde7.6b4c@MacMini.local> (raw)
In-Reply-To: <etPan.591d740e.515f007c.6b4c@MacMini.local>
On 18 maja 2017 at 12:15:29, Sebastian Gniazdowski (psprint@zdharma.org) wrote:
> Hello,
> it is really simple to keep collision lists sorted. However, I get error about typeset
> not being found. Debugged that typeset is inserted into builtintab. I am pretty exhausted,
> maybe someone will have a revelation on this. Debugged that typeset is being searched
> in:
Found it, missing return NULL here below, writing so that no one wastes time, will now test performance.
+ } else if ( cres > 0 ) {
+ /* Insert in front of the list, because first
+ * element, nodes[hashval], is larger, so new
+ * element has to be before it */
+ hn->next = hp;
+ ht->nodes[hashval] = hn;
+ if (++ht->ct >= ht->hsize * 2 && !ht->scan)
+ expandhashtable(ht);
+ return NULL;
--
Sebastian Gniazdowski
psprint /at/ zdharma.org
next prev parent reply other threads:[~2017-05-18 12:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-18 10:14 Sebastian Gniazdowski
2017-05-18 12:16 ` Sebastian Gniazdowski [this message]
2017-05-20 5:06 ` Sebastian Gniazdowski
2017-05-20 17:08 ` Improving zcompdump (Re: A patch with hashtable optimization, which doesn't work) Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=etPan.591d90ad.1190cde7.6b4c@MacMini.local \
--to=psprint@zdharma.org \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).