From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15918 invoked by alias); 1 Jun 2017 16:32:09 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 41192 Received: (qmail 24257 invoked from network); 1 Jun 2017 16:32:09 -0000 X-Qmail-Scanner-Diagnostics: from aok120.rev.netart.pl by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(85.128.245.120):SA:0(0.0/5.0):. Processed in 4.044354 secs); 01 Jun 2017 16:32:09 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=unavailable autolearn_force=no version=3.4.1 X-Envelope-From: psprint@zdharma.org X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: none (ns1.primenet.com.au: domain at zdharma.org does not designate permitted sender hosts) X-Virus-Scanned: by amavisd-new using ClamAV (19) Date: Thu, 1 Jun 2017 18:31:58 +0200 From: Sebastian Gniazdowski To: Bart Schaefer , zsh workers Message-ID: In-Reply-To: <170530224728.ZM25709@torch.brasslantern.com> References: <170528124337.ZM9444@torch.brasslantern.com> <170530224728.ZM25709@torch.brasslantern.com> Subject: Re: mikachu/badarrays (Re: Valgrind testing, ideas) X-Mailer: Airmail (231) MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On 31 maja 2017 at 07:47:59, Bart Schaefer (schaefer=40brasslantern.com) = wrote: > With respect to =22it doesn't work=22 -- in commits f4ab07b4 and b7c2dd= f6 > you say you're adding typeset -C and typeset -c to control PM=5FCACHELE= N > and PM=5FCHECKLEN but looking at the diffs you only added the argument > parsing; I can't find anywhere that PM=5FCACHELEN or PM=5FCHECKLEN are = ever > assigned to the parameter flags=3F > =20 > I believe I've now merged params.c ... I tried forcing both of the new > flags on for non-special PM=5FARRAY params in createparam(), and all te= sts > seem to pass except those involving the =24match array, which implies o= ne > of us did something wrong in setarrvalue() for post=5Fassignment=5Fleng= th. > I think. I've got slightly demotivated after Mikachu said the code doesn't work, b= ut you say you have merged this and it works=3F As for my thesis on Valgrind testing, I was now running for a week the ma= ny-test-cases-in-single-test-run method, and I can now say this is a very= plausible method. Valgrind messages appear, one just observes, scrolling= terminal, and if a report appears, it doesn't have to be connected with = distinct test case, it has its own context which is the source code and t= he single line pointed by Valgrind. I'm a happy Valgrind user with errors= like pm->gsu.s =3D &stdscalar=5Fgsu assigned instead of pm->gsu.a =3D &s= tdarray=5Fgsu reported (interestingly this one indirectly, as memory leak= ). One tip maybe, I do: if =5B=5B 2 -nt 1 =5D=5D; then =C2=A0 =C2=A0 colour-valgrind =24ZTST=5Fexe +Z -f =24ZTST=5Fsrcdir/ztst.z= sh =24file else =C2=A0 =C2=A0 colour-valgrind --leak-check=3Dfull =24ZTST=5Fexe +Z -f =24= ZTST=5Fsrcdir/ztst.zsh =24file fi to easily switch by touch =7B1=7C2=7D between errors checking and leak ch= ecking. Actually have also file =223=22, to disable the =22possibly lost=22= reports. -- Sebastian Gniazdowski psprint /at/ zdharma.org