From: Sebastian Gniazdowski <psprint@zdharma.org>
To: Bart Schaefer <schaefer@brasslantern.com>, zsh-workers@zsh.org
Subject: Re: Improving zcompdump (Re: A patch with hashtable optimization, which doesn't work)
Date: Sat, 3 Jun 2017 16:11:12 +0200 [thread overview]
Message-ID: <etPan.5932c380.2ae8944a.a149@MacMini.local> (raw)
On 20 maja 2017 at 19:08:09, Bart Schaefer (schaefer@brasslantern.com) wrote:
> } Tried to optimize mkautofn, to speed up sourcing zcompdump.
>
> How much does zcompdump actually help? Have you compared startup with
> and without it?
>
> There's a bunch of stuff in .zcompdump. Have you investigated whether
> certain parts of it are slower than others?
>
> One lesson learned with Completion/Base/Utility/_store_cache is that
> parsing array assignments is expensive.
I've wrapped sourcing zcompdump in compinit this way:
zmodload zsh/zprof
() {
builtin . "$_comp_dumpfile"
}
zprof | head -n 14
Then I tried with a) normal .zcompdump, and b) with modification – with _comps=( ), i.e. empty. Results seem to confirm what you said:
num calls time self name
-----------------------------------------------------------------------------------
1) 1 58,93 58,93 100,00% 58,93 58,93 100,00% (anon)
vs.
1) 1 12,81 12,81 100,00% 12,81 12,81 100,00% (anon)
There's 58-12=46 ms to win, a significant value when thinking in terms of instant Zsh startup, which today is rather a melody of the past, with zsh-syntax-highlighting and zsh-autosuggestions overloading all $widgets entries during startup, in a loop.
I would go in direction of implementing new trivial parser that would read key-value pairs and put them to hash. It might even predict required size for 1562 _comps elements in the hash (it's x4 AFAIR, saw in addhashnode2), so that no expandhashtable() will be called. There would be .zcompdump_comps file with the pairs. Nothing will break, old .zcompdump will work.
--
Sebastian Gniazdowski
psprint /at/ zdharma.org
next reply other threads:[~2017-06-03 14:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-03 14:11 Sebastian Gniazdowski [this message]
2017-06-04 0:54 ` Bart Schaefer
2017-06-04 7:18 ` Sebastian Gniazdowski
-- strict thread matches above, loose matches on Subject: below --
2017-05-18 10:14 A patch with hashtable optimization, which doesn't work Sebastian Gniazdowski
2017-05-18 12:16 ` Sebastian Gniazdowski
2017-05-20 5:06 ` Sebastian Gniazdowski
2017-05-20 17:08 ` Improving zcompdump (Re: A patch with hashtable optimization, which doesn't work) Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=etPan.5932c380.2ae8944a.a149@MacMini.local \
--to=psprint@zdharma.org \
--cc=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).