From: Sebastian Gniazdowski <psprint@zdharma.org>
To: Bart Schaefer <schaefer@brasslantern.com>, zsh-workers@zsh.org
Subject: Re: [PATCH] 2 modules, zsh/db, zsh/gdbm, bug-fixes
Date: Sat, 24 Jun 2017 06:56:14 +0200 [thread overview]
Message-ID: <etPan.594df0ee.dd58fa9.63ea@zdharma.org> (raw)
In-Reply-To: <170623205312.ZM27285@torch.brasslantern.com>
On 24 czerwca 2017 at 05:53:12, Bart Schaefer (schaefer@brasslantern.com) wrote:
> Yes, I would also prefer the vim folding be removed, and the use of
> CamelCapsVariableNames be made more like the rest of the code, but
> both of those seemed unnecessarily picky.
The folding helps in redis module, where set of GSU objects is devoted to 6 different types.
> } The #if 0 looks alarming.
>
> It's around code that was never present in db_gdbm.c before, and protects
> a function call that's "new" (in a historical sense) to the library. I
> think it's also nothing but an optimization, and therefore not essential.
I've reported bug report to GDBM (before writing [PATCH] mail). Got response with correct address to send the report. The problem is: gdbm_reorganize doesn't work correctly on NFS filesystems. Short test code:
https://github.com/zdharma/hacking-private/tree/master/gdbm
Effect on NFS:
https://asciinema.org/a/ocjBIM9sEcvnNovA9AkStSwsQ
> I've had a hard time deciding which of the warning functions is the
> right one to use in a given situation. zwarnnam() is usually meant to
> prefix the message with the name of a command that caused the error;
> it's not obvious that it should be used in a context where there is no
> command involved. (I haven't dug into whether that is the case for
> the instances you've called out.)
Yes me too had hard time deciding on this. I can add some names, no problem.
--
Sebastian Gniazdowski
psprint /at/ zdharma.org
next prev parent reply other threads:[~2017-06-24 4:56 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-22 9:04 Sebastian Gniazdowski
2017-06-22 9:05 ` Sebastian Gniazdowski
2017-06-23 9:29 ` Bart Schaefer
2017-06-23 8:36 ` Bart Schaefer
2017-06-23 21:30 ` Daniel Shahaf
2017-06-24 3:53 ` Bart Schaefer
2017-06-24 4:56 ` Sebastian Gniazdowski [this message]
2017-06-25 0:50 ` Daniel Shahaf
2017-06-26 2:40 ` Sebastian Gniazdowski
2017-06-24 17:36 ` Bart Schaefer
2017-06-25 8:06 ` Sebastian Gniazdowski
2017-06-25 11:22 ` Sebastian Gniazdowski
2017-06-25 22:52 ` Bart Schaefer
2017-06-27 5:46 ` Sebastian Gniazdowski
2017-06-27 8:39 ` Daniel Shahaf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=etPan.594df0ee.dd58fa9.63ea@zdharma.org \
--to=psprint@zdharma.org \
--cc=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).