From: Sebastian Gniazdowski <psprint@zdharma.org>
To: Phil Pennock <zsh-workers+phil.pennock@spodhuis.org>
Cc: zsh-workers@zsh.org
Subject: Re: Localize MATCH, MBEGIN, etc. in _zstyle and _globquals
Date: Thu, 2 Nov 2017 20:09:15 +0100 [thread overview]
Message-ID: <etPan.59fb6d5b.6529e0b6.98a8@zdharma.org> (raw)
In-Reply-To: <etPan.59f655ed.1f659851.98a8@AirmailxGenerated.am>
On 29 Oct 2017 at 23:07:21, Phil Pennock (zsh-workers+phil.pennock@spodhuis.org) wrote:
> _main_complete localizes `match` already. So if we don't localize all
> of them in the same place then we're risking inconsistency, no matter
> what.
Worth noting it doesn't localize $mbegin and $mend. Also, it uses local not local -a for $match, which is a minor thing.
> Anyone know of a good reason to not just localize _all_ of the =~
> non-BASH_REMATCH variables in _main_complete so that they're always
> isolated to the completion-system, if =~ or -regex-match or -pcre-match
> is used within the completion system?
I'm little not current with regex match variables, so not sure what you mean by "=~" variables, and why not localize non-BASH_REMATCH variables too (or if it's that Zsh code doesn't use them, then it's ok for me, logical to not localize them).
--
Sebastian Gniazdowski
psprint /at/ zdharma.org
next prev parent reply other threads:[~2017-11-02 19:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-29 11:40 Sebastian Gniazdowski
2017-10-29 22:07 ` Phil Pennock
[not found] ` <etPan.59f655ed.1f659851.98a8@AirmailxGenerated.am>
2017-11-02 19:09 ` Sebastian Gniazdowski [this message]
2017-11-02 19:57 ` Phil Pennock
[not found] ` <etPan.59fb7aea.497d9379.98a8@AirmailxGenerated.am>
2017-11-04 16:57 ` Sebastian Gniazdowski
2017-11-04 19:03 ` Bart Schaefer
2017-11-05 16:20 ` Sebastian Gniazdowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=etPan.59fb6d5b.6529e0b6.98a8@zdharma.org \
--to=psprint@zdharma.org \
--cc=zsh-workers+phil.pennock@spodhuis.org \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).