From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29162 invoked by alias); 8 Jan 2018 12:42:36 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 42246 Received: (qmail 16854 invoked by uid 1010); 8 Jan 2018 12:42:35 -0000 X-Qmail-Scanner-Diagnostics: from aok120.rev.netart.pl by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(85.128.245.120):SA:0(-1.9/5.0):. Processed in 8.798338 secs); 08 Jan 2018 12:42:35 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham autolearn_force=no version=3.4.1 X-Envelope-From: psprint@zdharma.org X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | X-Virus-Scanned: by amavisd-new using ClamAV (10) Date: Mon, 8 Jan 2018 13:29:10 +0100 From: Sebastian Gniazdowski To: Mikael Magnusson , zsh-workers@zsh.org Message-ID: In-Reply-To: <20180107140939.6930-1-mikachu@gmail.com> References: <20180107140939.6930-1-mikachu@gmail.com> Subject: Re: PATCH: Free stuff properly in zsh/pcre module X-Mailer: Airmail (467) MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On 7 stycznia 2018 at 15:09:39, Mikael Magnusson (mikachu=40gmail.com) wr= ote: > =46ix a few memleaks of the hints structure, also make sure to free all= > the allocated stuff when the module is unloaded. > =20 > --- > =20 > If you run > % zmodload zsh/pcre; pcre=5Fcompile hey; repeat 1000000; do pcre=5Fstud= y; done > then zsh mem usage goes up by about 100MB each time. Maybe Valgrind automatic tests can be integrated for next Zsh release=3F = I've updated the README: https://github.com/zdharma/VATS-zsh It much helps to track things like the above reported leaks. Today, I was= extending a module (an external one) and by logic, the changes couldn't = cause any error or leak, but I just ran 7 test-sets, in 5 minutes (exclud= ing the time devoted to updates needed for optimized Zsh build, which was= skipping some function calls), and was done. --=C2=A0 Sebastian Gniazdowski=C2=A0 psprint /at/ zdharma.org=C2=A0