From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12594 invoked by alias); 19 Mar 2018 14:24:16 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 42484 Received: (qmail 8642 invoked by uid 1010); 19 Mar 2018 14:24:16 -0000 X-Qmail-Scanner-Diagnostics: from aok120.rev.netart.pl by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(85.128.245.120):SA:0(-1.9/5.0):. Processed in 1.839339 secs); 19 Mar 2018 14:24:16 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham autolearn_force=no version=3.4.1 X-Envelope-From: psprint@zdharma.org X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | X-Virus-Scanned: by amavisd-new using ClamAV (17) Date: Mon, 19 Mar 2018 15:24:08 +0100 From: Sebastian Gniazdowski To: Oliver Kiddle , Joey Pabalinas Cc: "=?utf-8?Q?zsh-workers=40zsh.org?=" , Joey Pabalinas Message-ID: In-Reply-To: <20180319090738.hyri7bnr5siowjuk@gmail.com> References: <20171223221910.vmob22b7uosan5os@nibbler.alyptik.lan> <7096.1521281564@thecus> <20180319090738.hyri7bnr5siowjuk@gmail.com> Subject: Re: Why sourcing a file is not faster than doing a loop with eval, zle -N X-Mailer: Airmail (467) MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline On 19 marca 2018 at 10:07:38, Joey Pabalinas (joeypabalinas@gmail.com) wrote: > After spending a bit of time writing up a patch and testing it, getline() > unfortunately didn't seem to solve the original performance problem By "original problem" you mean: sig-mask being updated too often (through a syscall, like strace reported) ? AFAIR Bart patch (committed) vs. Peter patch (fgets, not commited) was resolved to: fgets is faster, but it has problems, and Bart's patch is too very fast, and correctly solves many-syscalls problem. So if you wrote the same what Peter did, but instead of fgets you used getline, then it should solve too the many-syscalls problem and be even faster than HEAD. So maybe by "original issue" you mean something else, probably: "getline should be significantly faster than current HEAD (Bart's patch commited)" ? So in general all this would mean that getline doesn't provide performance gains comparing to current HEAD? -- Sebastian Gniazdowski psprint /at/ zdharma.org