From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A,RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 14941 invoked from network); 5 Nov 2022 22:13:55 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 5 Nov 2022 22:13:55 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1667686435; b=L/xCJhxpseWMAq4hV6YNwd7mxR5ylLiPX3Gkrg1CnbarvwP9wa3687Rnr/mMbjqlpq4RyqHHDi jBOVEkYNfq2cXqgnRop627jPgG1Bn7X955oyB1kNK6XXuy14T1ZkTEzK3MVVXDik0/oqt35yYe 68TuTBkQqydLhm3UvAiSNNaBK65PLb9YNF4Vrp76cCcHLQPkeYu1xqj2/bVsVG0LXgHqfbfSHO PQOq1AsBQHwGcTWZVQhxK8BnS3r7TU2FJ25J+onzrmszdb3t1lMEA2sdDZaTtEW+TWwfaqhfRs XIyM6/RTNi7f+DwZSnh9/J8q6Y/z6yMF6n8JKnG46nTtvQ==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (iris.zentaur.org) smtp.remote-ip=198.58.127.206; dkim=pass header.d=zentaur.org header.s=dkim20200120 header.a=rsa-sha256; dmarc=pass header.from=zentaur.org; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1667686435; bh=3R3sKBwPlV9vUIRl986DkxxczTITFvkl6/AVcd/GHQE=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:To:Subject:MIME-Version:Date:Message-ID:DKIM-Signature: DKIM-Signature; b=gcw84gumw8j10KbKrHOyJ6IUHrede/l38RLXNSOijyp+vcy9Z9LN5JrY4WoNOb+4WxXnDzSv88 Ip89LgB6+ydqa1450uU9d3xVD875rFpzkFzf1UIgYjC81ukjsO0//KwWoVq5AuQiVmlQgf4p/c BG3ICmrzxIVjnrLyiJCe4oy391a0szb7wBSJrq2vMl0Js+LOv8fLWKbQsXppN/Kpgg5r54Vzvg eCYd6/cw9o1C2DUKgAMlHhMWWFFPsbFzhGC9B18hqF5RMi7VvE27NhUwZcOIMfxhvg6DJhJbdm T7k4q/u+VsDwevcrnivW4CIcLLTi0QHAxi52Ut6/9gLkVg==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From :Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=3R3sKBwPlV9vUIRl986DkxxczTITFvkl6/AVcd/GHQE=; b=cJ1CoqGHozLIUTmld0y5HujJYU j+r0eYoFUvO64YL1XyAuiTLYZq6yLYPnQ1KKzdpVgaheutBY37Rp9OiLcXehcXwOeSRiihs+A/yDO WS9PxmOgHBH9av/h03C74NKcEgRHTA6QztJ5sgqFlK+tdP7QRWq0Hr/X22ti/hp8cLN9nu0exn7Cz /q0NtfCGljLylzkzso+XzvAkPkXxXm1b2MMMdnP79aLxzk+jsi9zJxhFndRb4KpJgTxBbwWqun0zG RgK9enQuMRreQP25JU8UrcRyArJ7nutgNXdubFkpAVKHocU0o1gg38WnSTZEykdc84hkO8fPBgan9 VosucB1g==; Received: by zero.zsh.org with local id 1orRQI-000Mwo-UD; Sat, 05 Nov 2022 22:13:54 +0000 Authentication-Results: zsh.org; iprev=pass (iris.zentaur.org) smtp.remote-ip=198.58.127.206; dkim=pass header.d=zentaur.org header.s=dkim20200120 header.a=rsa-sha256; dmarc=pass header.from=zentaur.org; arc=none Received: from iris.zentaur.org ([198.58.127.206]:59154) by zero.zsh.org with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) id 1orRQ3-000Mcy-JJ; Sat, 05 Nov 2022 22:13:40 +0000 Received: from iris.zentaur.org (localhost [127.0.0.1]) by iris.zentaur.org (Postfix) with ESMTP id 4N4Wwf2tTWz3wZj for ; Sat, 5 Nov 2022 22:13:38 +0000 (UTC) Authentication-Results: iris.zentaur.org (amavisd-new); dkim=pass (2048-bit key) reason="pass (just generated, assumed good)" header.d=zentaur.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=zentaur.org; h= content-transfer-encoding:content-type:content-type:in-reply-to :from:from:references:to:content-language:subject:subject :user-agent:mime-version:date:date:message-id; s=dkim20200120; t=1667686418; x=1667690019; bh=3R3sKBwPlV9vUIRl986DkxxczTITFvkl 6/AVcd/GHQE=; b=GqgCwgkJzl2iZd5Z14pF7d+zGT9WZCrJP6+PZKR1+foe9ZR0 pzxipJxFmu+hS+RQGK5q5nN3V24683jXy9aEz1x3VOjx91XIgG0GdE9fsLwZtnY3 sZgx0dVXF1CSgpOZ4nkOU2pUId+Z6XzOlIp9jKVSp3RSz1MWVV8n8euUBMwLseTa S8wHV94+dFa/SKR3BTEI6QpXpWkD7Pn+YbFUSLOcw4r30w7gKeP12UWGft79eraH DOs9oFkqS9QMFKZt5R5SPRnKyi1ymLd/1VtQI0rSZn0HZFOQYER/EMRdrXQLNWM0 /glaQ8QSTJO3kizFvQlOgB4dqc8sDb6p61pQng== X-Virus-Scanned: amavisd-new at iris.zentaur.org Received: from iris.zentaur.org ([127.0.0.1]) by iris.zentaur.org (iris.zentaur.org [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id dChqXpyBwJE4 for ; Sat, 5 Nov 2022 22:13:38 +0000 (UTC) Received: from [192.168.72.136] (unknown [136.50.213.220]) by iris.zentaur.org (Postfix) with ESMTPSA id 4N4Wwd6szJz3wZb for ; Sat, 5 Nov 2022 22:13:37 +0000 (UTC) Message-ID: Date: Sat, 5 Nov 2022 17:13:28 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.3 Subject: Re: I think I found a serious bug in zstrtoul_underscore Content-Language: en-US To: zsh-workers@zsh.org References: From: Clinton Bunch In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed X-Antivirus: Avast (VPS 221105-6, 11/5/2022), Outbound message X-Antivirus-Status: Clean Content-Transfer-Encoding: quoted-printable X-Seq: 50877 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: , List-Subscribe: , List-Unsubscribe: , List-Post: List-Owner: List-Archive: On 11/5/2022 4:57 PM, Clinton Bunch wrote: > This is how I'm calling it: > > if (!zstrtoul_underscore(OPT_ARG(ops, 'L'), &lower)) { > > lower is declared as a zulong. > > When fed a negative number it seg faults, on Rocky Linux 8 at least. > > Example: > > helikon[~/tmp/zsh]% getrandom -L 0 -U $(( 2**32-1)) > Test before convert -L > Test after convert -L > 377689410 > helikon[~/tmp/zsh]% getrandom -L -1 -U 5 > Test before convert -L > zsh: segmentation fault (core dumped)=C2=A0 ~/local/bin/zsh > > I've verified this on FreeBSD 13.1 and Solaris 11.4 as well, so unless=20 I'm calling it wrong, this seems like a serious bug.