From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 2927 invoked from network); 17 Jul 2023 15:58:37 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 17 Jul 2023 15:58:37 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1689609517; b=bj3zI8K+JStmlrjjBy/mX052zJoLzb+n322k4zDOA3Uob9p19ET+mggiLovhywiFfvVXT7DnPS HMSAIZbN4H6s8LHG+5zuqObQOJPlaxNWZ2s7NmQ0xybaK4Ll6kf6MzZiUpQs6xJrA12EmsYBZL VbAzv3k1LdFxdY+Wf8kmphYhuB71nh6BEcX2Ruh9MQo8WtEqRc64l5z73ACumWaH4yBRykPWQE udE9WC6hTF1Mcyxph/+44Ejnwg8tw3Sn2kjZAupf6t3a/CP/BT2uxDdqOdX3AaFMNyskRAFX2P aM3UQSvEI6/+eKPg6/iGjnHwBAGxZvac0vyeQFbKbgM3oA==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (out4-smtp.messagingengine.com) smtp.remote-ip=66.111.4.28; dkim=pass header.d=dana.is header.s=fm3 header.a=rsa-sha256; dkim=pass header.d=messagingengine.com header.s=fm3 header.a=rsa-sha256; dmarc=none header.from=dana.is; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1689609517; bh=EAM8itXmTqCN1+60dkK7zQe25qpNAxF603cYD2eI7GA=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Type:Subject:Cc:To:From:Date:References:In-Reply-To: Message-ID:MIME-Version:DKIM-Signature:DKIM-Signature:DKIM-Signature; b=MJKNFekVouLFUoYv0rNoZXSGQ5+r6qMclfFUv9VmQlIKog90yQOIstM/gOK/alFXBc3qYI8PFz exhbrMnbQ0ubbFoDQoHVuf7vwSiQjN/X+DrMtYaQVM/uGPpyBGd0Gzf92nJVsQYLZlQTK8bnja p5gXQuzlmta7UbzQyDnt+D3WTCD2KyuY5SiM8it09v379Ot1CjiCYx0KmXzSZdEh2YXaMo7OzI jVgZ0YKlOz66PQauYAJKgwsdE187wYLZn0rywmZRJghZoeVguhK/vLaYohLkJx46eFfAfEPZPH VgmDd0PBEzDKEI3Wr07QXPWV/0/Kefs2ZfvSHZ2TyRGoXA==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Type:Subject:Cc:To:From:Date: References:In-Reply-To:Message-Id:Mime-Version:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=TTmj2KZSYTwpL5SuBhYh8PQq67MJVjdSso1evI7GehM=; b=fP2XyumJxHldcIMJ05xhcawsBn cEMZHhb7FUen885oysQk3XA7PBbeLPmodHT1kflW9+xFqUOE9ben7133wKL6Cv/Zd48ZrA+g3Nr1d 4VagpK7yY793i+Vv1CcyvsebU1UEguvkEpgHPtfI5rvgi095R5IFysPXkyyBnA8GJ1h2IIIXj1jkG 7GMePazrerdku/shm6+UdxSICVLqEC1Sc3AbK+SqZNX9YccbEXs81VMG14VrfXOJUo8gSO44iHxmK Wg9dqmDrSCEEieJNX39/2sjWnZOvEyRtUZ80m2hY2bMKeutgATT5fT83h71PHm4uL5Oz2lDvgS6Jv EI+CEP8w==; Received: by zero.zsh.org with local id 1qLQcO-000DgR-LP; Mon, 17 Jul 2023 15:58:36 +0000 Authentication-Results: zsh.org; iprev=pass (out4-smtp.messagingengine.com) smtp.remote-ip=66.111.4.28; dkim=pass header.d=dana.is header.s=fm3 header.a=rsa-sha256; dkim=pass header.d=messagingengine.com header.s=fm3 header.a=rsa-sha256; dmarc=none header.from=dana.is; arc=none Received: from out4-smtp.messagingengine.com ([66.111.4.28]:56741) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_256_GCM_SHA384:256) id 1qLQWy-000DFL-Sc; Mon, 17 Jul 2023 15:53:02 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 4100E5C00DA; Mon, 17 Jul 2023 11:52:58 -0400 (EDT) Received: from imap50 ([10.202.2.100]) by compute5.internal (MEProxy); Mon, 17 Jul 2023 11:52:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dana.is; h=cc:cc :content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; t=1689609178; x=1689695578; bh=TT mj2KZSYTwpL5SuBhYh8PQq67MJVjdSso1evI7GehM=; b=AWVWNIosd7Q2qmqqch 9AnIfBaFlc2p9mf5134MNa7O27ZZFVsqEnXqEr8pLD9jfO8OfvtpzXBT6w5ah0M5 8Avr3sFL8wLTiWAYijexX1Lu842k9zrULvjX2l0LwYo/pGs/jW9udpSshiS6atgp ifiWFkLEDmj6eMM8eYfrybivm4JRFnkqQI5NS9BExWmztGYUeZDL7zVkiv0VHyQ4 cWnZ1zjBaJ5k8hFuL5Nt/RQ9Nl+8+xLO5Br0Kj0tohrxAKISQqK0PNdM5v61iJCD yJTpjftGXB0wtMy8/rsi7vTBStiDu3fnk6A66gqxVWk1xzHMSs0qAHr4if82+4RC lBpQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1689609178; x=1689695578; bh=TTmj2KZSYTwpL 5SuBhYh8PQq67MJVjdSso1evI7GehM=; b=jO4MM8pbImMdqck76HvYZfZhA6OgS 89le1552UrjzXNvJRlhAwPqQQJWVlrFHh2sO9gGwV/Re30VbGljColZcj0edbUCd fPpO0b/etQHKmW37jrZ8/Aky/oW7gTMdrY+0TeB9GU7HfP951Klb7hyyEGQLeU8e 9e5mDpbNZdnMt/N2M132Ls9f2YWvc7xtu4sFDVDCgBVh1cFfFbV7IvlTU+IU7VKg dSipxZsg1ktgzAkORzFmErTKxsJ8o8Fz2RZzbR1etM1VdenHlTrWcqe+V5mn2vbD x+m90dgGaZEgEnHd7/84S/sAmixoV17OPAdcVK8R0hKYYPBkeoh+NCETw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrgedvgdelgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefofgggkfgjfhffhffvvefutgesthdtredtreertdenucfhrhhomhepuggrnhgr uceouggrnhgrsegurghnrgdrihhsqeenucggtffrrghtthgvrhhnpefggfeifeetueeutd eitddttdfggedtleevjeelgfekteekhfekgfdtgeefueelueenucevlhhushhtvghrufhi iigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegurghnrgesuggrnhgrrdhish X-ME-Proxy: Feedback-ID: i9be146f9:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id B6A631700089; Mon, 17 Jul 2023 11:52:57 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-531-gfdfa13a06d-fm-20230703.001-gfdfa13a0 Mime-Version: 1.0 Message-Id: In-Reply-To: References: <422608219.9324398.1673947338127@mail.virginmedia.com> <974250f6-d143-4543-872e-05c72f67a98c@app.fastmail.com> Date: Mon, 17 Jul 2023 10:52:01 -0500 From: dana To: "Bart Schaefer" Cc: "Zsh hackers list" , "Peter Stephenson" Subject: Re: [PATCH] Re: Bug: Callback to widget set with `zle -Fw ` shouldn't change $LASTWIDGET Content-Type: text/plain X-Seq: 51948 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: , List-Subscribe: , List-Unsubscribe: , List-Post: List-Owner: List-Archive: On Mon 17 Jul 2023, at 10:17, Bart Schaefer wrote: > The patch from the start of this thread has never been committed, so > is not directly related. That is, if the Thingy is invalid, it's not > $LASTWIDGET that's making the bad reference here, so fixing > save/restore there probably will not resolve the problem. Sorry, i'm not very familiar with the LASTWIDGET mechanism, but by the patch at the start of this thread you mean workers/51310, right? It was committed as f93ad02b94bd I should have mentioned that i did a (manual) bisect to confirm that that is when the problem started for me; the poster in workers/51673 found the same, with what sounds like a very similar configuration (though they didn't provide any other details). I can't get the problem to occur on a build off the preceding commit or on the 5.9 release I did examine the functions the trace references before; the _zsh_highlight_widget_orig... one simply calls _zsh_highlight_call_widget, and that one calls zle before calling another highlight function (but the crash happens in zle so it's not getting to that). The autosuggest ones are a little more elaborate. I can get back to it later dana