From: Peter Stephenson <p.w.stephenson@ntlworld.com>
To: zsh-workers@zsh.org
Subject: Re: [PATCH] Make --disable-multibyte warn, since the test suite fails in that configuration. (was: Re: Test failures in --disable-multibyte)
Date: Sun, 05 Jan 2020 18:20:30 +0000 [thread overview]
Message-ID: <fad99155a576d89e7fb91288a0d6adde047db7a0.camel@ntlworld.com> (raw)
In-Reply-To: <20200103201102.o7ezzd6ccxxih7fb@tarpaulin.shahaf.local2>
On Fri, 2020-01-03 at 20:11 +0000, Daniel Shahaf wrote:
> Here's a draft. Probably needs wordsmithing.
Sorry to be slow --- Definitely in the target area; I'm wondering about
> + # Some requisite functions are missing.
> + AC_MSG_WARN([Multibyte support disabled due to missing functions: $zfuncs_absent])
> + AC_MSG_WARN([Building without multibyte support is strongly discouraged and may cause errors in 'make test'.])
where the user doesn't have a lot of choice about what they're building,
so discouraging it is a bit pointless. I'd be tempted to omit that bit
here.
pws
next prev parent reply other threads:[~2020-01-05 18:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-31 18:39 Test failures in --disable-multibyte Daniel Shahaf
2019-12-31 19:46 ` Peter Stephenson
2020-01-01 13:44 ` Daniel Shahaf
2020-01-01 18:01 ` Peter Stephenson
2020-01-02 11:30 ` Daniel Shahaf
2020-01-03 10:15 ` Peter Stephenson
2020-01-03 20:11 ` [PATCH] Make --disable-multibyte warn, since the test suite fails in that configuration. (was: Re: Test failures in --disable-multibyte) Daniel Shahaf
2020-01-05 18:20 ` Peter Stephenson [this message]
2020-01-05 19:13 ` Daniel Shahaf
2020-01-06 9:44 ` Peter Stephenson
2019-12-31 20:23 ` Test failures in --disable-multibyte dana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fad99155a576d89e7fb91288a0d6adde047db7a0.camel@ntlworld.com \
--to=p.w.stephenson@ntlworld.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).