From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2]) by inbox.vuxu.org (OpenSMTPD) with ESMTP id a62469e6 for ; Sun, 5 Jan 2020 18:21:19 +0000 (UTC) Received: (qmail 8537 invoked by alias); 5 Jan 2020 18:21:14 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 45243 Received: (qmail 4731 invoked by uid 1010); 5 Jan 2020 18:21:14 -0000 X-Qmail-Scanner-Diagnostics: from know-smtprelay-omc-9.server.virginmedia.net by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.102.1/25684. spamassassin: 3.4.2. Clear:RC:0(80.0.253.73):SA:0(-2.0/5.0):. Processed in 4.31058 secs); 05 Jan 2020 18:21:14 -0000 X-Envelope-From: p.w.stephenson@ntlworld.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at _smtprelay.virginmedia.com designates 80.0.253.73 as permitted sender) X-Originating-IP: [86.16.88.158] X-Authenticated-User: p.w.stephenson@ntlworld.com X-Spam: 0 X-Authority: v=2.3 cv=Ke38TzQD c=1 sm=1 tr=0 a=MiHCjVqLJ44lE3bxSlffFQ==:117 a=MiHCjVqLJ44lE3bxSlffFQ==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=IkcTkHD0fZMA:10 a=3s8kuV3SXxjCr-rDU1IA:9 a=QEXdDO2ut3YA:10 Message-ID: Subject: Re: [PATCH] Make --disable-multibyte warn, since the test suite fails in that configuration. (was: Re: Test failures in --disable-multibyte) From: Peter Stephenson To: zsh-workers@zsh.org Date: Sun, 05 Jan 2020 18:20:30 +0000 In-Reply-To: <20200103201102.o7ezzd6ccxxih7fb@tarpaulin.shahaf.local2> References: <20200101134457.kdzfrmlyzjwptxaz@tarpaulin.shahaf.local2> <64e62682e403332a89322b7f24983fa009c19fc0.camel@ntlworld.com> <46b2aa40-adcb-44ff-8e39-df98a9b2d235@www.fastmail.com> <1578046551.4581.1.camel@samsung.com> <20200103201102.o7ezzd6ccxxih7fb@tarpaulin.shahaf.local2> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-CMAE-Envelope: MS4wfAx7nmottSLZVti5ALYXl+aPy2kNZ+TFJwQO4NYMAWFlW+q8KOgRkCZx1LaXhH0nfLAm4uaWm5OBLLktFckIeZxtGjcVtqJzwAtVeXfkDvk1SEDgVo9J 1GsrT/E2DCcAFG/Ec4Hyj9Z3ZSdO4L6zt8/OIWkOb0ZNGLyzqYnoOFzV On Fri, 2020-01-03 at 20:11 +0000, Daniel Shahaf wrote: > Here's a draft. Probably needs wordsmithing. Sorry to be slow --- Definitely in the target area; I'm wondering about > + # Some requisite functions are missing. > + AC_MSG_WARN([Multibyte support disabled due to missing functions: $zfuncs_absent]) > + AC_MSG_WARN([Building without multibyte support is strongly discouraged and may cause errors in 'make test'.]) where the user doesn't have a lot of choice about what they're building, so discouraging it is a bit pointless. I'd be tempted to omit that bit here. pws