zsh-workers
 help / color / Atom feed
* [PATCH] remove 'appendhistory' from zsh-newuser-install
@ 2020-01-04 22:08 Andrey Butirsky
  2020-01-05 17:49 ` Daniel Shahaf
  0 siblings, 1 reply; 2+ messages in thread
From: Andrey Butirsky @ 2020-01-04 22:08 UTC (permalink / raw)
  To: zsh-workers

[-- Attachment #1: Type: text/plain, Size: 949 bytes --]

Hello,
could we remove 'appendhistory' option from zsh-newuser-install, since 
it actually 'on' by default and new users unlikely would like to change it?

---
  Functions/Newuser/zsh-newuser-install | 1 -
  1 file changed, 1 deletion(-)

diff --git a/Functions/Newuser/zsh-newuser-install b/Functions/Newuser/zsh-newuser-install
index e4028fd50..60ac16b13 100644
--- a/Functions/Newuser/zsh-newuser-install
+++ b/Functions/Newuser/zsh-newuser-install
@@ -899,7 +899,6 @@ __zni_options_config() {
    # The "no" prefix is used to indicate options on by default.
    __zni_apply_defaults -o autocd '' "Change directory given just path." \
      extendedglob '' "Use additional pattern matching features." \
-    appendhistory '' "Append new history lines instead of overwriting." \
      '!nomatch' '' "Unmatched patterns cause an error." \
      '!beep' '' "Beep on errors." \
      notify '' "Immediately report changes in background job status."


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] remove 'appendhistory' from zsh-newuser-install
  2020-01-04 22:08 [PATCH] remove 'appendhistory' from zsh-newuser-install Andrey Butirsky
@ 2020-01-05 17:49 ` Daniel Shahaf
  0 siblings, 0 replies; 2+ messages in thread
From: Daniel Shahaf @ 2020-01-05 17:49 UTC (permalink / raw)
  To: Andrey Butirsky, zsh-workers

Andrey Butirsky wrote on Sat, 04 Jan 2020 22:08 +00:00:
> Hello,
> could we remove 'appendhistory' option from zsh-newuser-install, since 
> it actually 'on' by default and new users unlikely would like to change it?
> 
> ---

Yes, I agree.  Applied.

The diff did not apply cleanly, presumably because it was sent with
format=flowed.  To prevent leading/trailing whitespace from being munged
you can either send patches as attachments, disable format=flowed in
Thunderbird (https://wiki.openstack.org/wiki/MailingListEtiquette#Thunderbird),
or mark the unidiff as "preformatted text" in Thunderbird's editor.

Thanks for the patch,

Daniel

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-04 22:08 [PATCH] remove 'appendhistory' from zsh-newuser-install Andrey Butirsky
2020-01-05 17:49 ` Daniel Shahaf

zsh-workers

Archives are clonable: git clone --mirror http://inbox.vuxu.org/zsh-workers

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://inbox.vuxu.org/vuxu.archive.zsh.workers


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git