zsh-workers
 help / color / mirror / code / Atom feed
From: Tanaka Akira <akr@m17n.org>
To: zsh-workers@sunsite.auc.dk
Subject: Re: _cvs update
Date: 04 Oct 2000 23:06:14 +0900	[thread overview]
Message-ID: <hvobsx0zoo9.fsf@coulee.m17n.org> (raw)
In-Reply-To: <1001004101414.ZM21914@candle.brasslantern.com> (Bart Schaefer's message of "Wed, 4 Oct 2000 10:14:14 +0000")

In article <1001004101414.ZM21914@candle.brasslantern.com>,
  "Bart Schaefer" <schaefer@candle.brasslantern.com> writes:

> Anything that makes a query against the repository should respect the
> remote-access style, the way _cvs_revisions does.  You handled that in
> _cvs_(top|sub)_modules but not in _cvs_vendor_branches.

OK.  This patch do that.

However I think _cvs needs another style name to control cvs
invocation.  Because it may be slow even with local repository.
Currently,  remote-access style prevents local access as well as
remote access.  I think it's not so correct.

Index: Completion/User/_cvs
===================================================================
RCS file: /cvsroot/zsh/zsh/Completion/User/_cvs,v
retrieving revision 1.13
diff -u -r1.13 _cvs
--- Completion/User/_cvs	2000/10/04 05:10:20	1.13
+++ Completion/User/_cvs	2000/10/04 13:48:03
@@ -744,11 +744,14 @@
 (( $+functions[_cvs_vendor_branches] )) ||
 _cvs_vendor_branches () {
   local expl vendor_branch
-  if [[ -n $opt_args[-b] ]]; then
-    _cvs_extract_vendor_branch -b "$opt_args[-b]" "$cvsroot" "$line[1]" \
-      vendor_branch
-  else
-    _cvs_extract_vendor_branch "$cvsroot" "$line[1]" vendor_branch
+  vendor_branch=()
+  if zstyle -T ":completion:${curcontext}:" remote-access; then
+    if [[ -n $opt_args[-b] ]]; then
+      _cvs_extract_vendor_branch -b "$opt_args[-b]" "$cvsroot" "$line[1]" \
+	vendor_branch
+    else
+      _cvs_extract_vendor_branch "$cvsroot" "$line[1]" vendor_branch
+    fi
   fi
   if (( $#vendor_branch )); then
     _wanted values expl 'vendor branch' compadd -a vendor_branch
-- 
Tanaka Akira


  reply	other threads:[~2000-10-04 14:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2000-10-04  5:03 Tanaka Akira
2000-10-04 10:14 ` Bart Schaefer
2000-10-04 14:06   ` Tanaka Akira [this message]
2000-10-04 16:10     ` Bart Schaefer
2000-10-05  8:29 Sven Wischnowsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=hvobsx0zoo9.fsf@coulee.m17n.org \
    --to=akr@m17n.org \
    --cc=zsh-workers@sunsite.auc.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).