zsh-workers
 help / color / mirror / code / Atom feed
From: Hrvoje Niksic <hniksic@srce.hr>
To: Zoltan Hidvegi <hzoli@cs.elte.hu>
Cc: zsh-workers@math.gatech.edu
Subject: Re: Purified zsh-3.0.1
Date: 11 Nov 1996 02:27:39 +0100	[thread overview]
Message-ID: <kigloc9pgj8.fsf@jagor.srce.hr> (raw)
In-Reply-To: Zoltan Hidvegi's message of Mon, 11 Nov 1996 02:01:38 +0100 (MET)

Zoltan Hidvegi (hzoli@cs.elte.hu) wrote:
> ***************
> *** 1787,1792 ****
> --- 1790,1797 ----
>   	pm->flags |= PM_EXPORTED;
>       if (pm->flags & PM_EXPORTED)
>   	pm->env = addenv(s, u);
> +     else
> + 	zsfree(u);
>   }

This one is wrong, I'm afraid.  Here I get FUM (Freeing Uninitialized
Memory), which is *bad*.

If I use only the first part of the patch, there are no FUMs, but the
leaks seem to persist. :(

BTW, after quitting zsh, it seems that a descriptor is in use, which
shouldn't be:

         FIU: file descriptor 10: "/home/srce/hniksic/.zcompctl", O_RDONLY
         Duplication of file descriptor 5.
         File info: crwx------  1 hniksic  tty              0 Nov 11 02:25
         File position: 1787837
         This file descriptor was allocated from:
               fcntl          [libc.so.1]
               movefd         [utils.c:877]
               source         [init.c:781]
               bin_dot        [builtin.c:4726]
               execbuiltin    [builtin.c:185]
               execcmd        [exec.c:1653]

Why does .zcompctl stay open (.zcompctl is the name of a file in my
home directory that I source from .zshrc)?

-- 
Hrvoje Niksic <hniksic@srce.hr> | Student at FER Zagreb, Croatia
--------------------------------+--------------------------------
I'm a Lisp variable -- bind me!


      reply	other threads:[~1996-11-11  1:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
1996-11-10  4:25 Hrvoje Niksic
1996-11-10  5:12 ` Geoff Wing
1996-11-10  5:22   ` Hrvoje Niksic
1996-11-10  5:52     ` Geoff Wing
1996-11-11  1:01 ` Zoltan Hidvegi
1996-11-11  1:27   ` Hrvoje Niksic [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=kigloc9pgj8.fsf@jagor.srce.hr \
    --to=hniksic@srce.hr \
    --cc=hzoli@cs.elte.hu \
    --cc=zsh-workers@math.gatech.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).