From: Carlo <catull@gmail.com>
To: zsh-workers@zsh.org
Subject: Re: PATCH _cd: completion fails for
Date: Mon, 30 Dec 2013 09:23:36 +0000 (UTC) [thread overview]
Message-ID: <loom.20131230T100101-18@post.gmane.org> (raw)
In-Reply-To: <131228000041.ZM25439@torch.brasslantern.com>
Bart Schaefer <schaefer <at> brasslantern.com> writes:
> After looking at this for a while I think you are close, but not quite
> right. There are two uses of $tmpWpath, but I believe only one of them
> needs additional quoting.
>
> This also needs to be careful to quote each element of the array before
> the elements are joined, because the reference is inside double-quotes.
Hello Bart
I am afraid, your patch doesn't work for me.
Fetched zsh 5.0.4, built it on MacOS X 10.9.1.
When I hit the tab, the shell immediately exits.
It happens when it type
cd /usr/lo<TAB>
as well as
ls /tmp/g<TAB>
Applying your patch - using _cd from a fresh git checkout - hasn't fixed it.
The problem is not a space in a path, but in the handling of tab characters.
I have been using the same zsh key-bindings for years on various OS
without incurring this problem.
Reverted back to 5.0.2, where the tab character works as expected.
Regards,
--
Carlo
next prev parent reply other threads:[~2013-12-30 9:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-11 19:14 Compatibility issue in the _django completion Alexey Bezhan
2013-12-27 21:15 ` PATCH _cd: completion fails for "cd .." if $PWD/.. contains a space Alexey Bezhan
2013-12-28 8:00 ` Bart Schaefer
2013-12-30 9:23 ` Carlo [this message]
2013-12-30 16:13 ` PATCH _cd: completion fails for Carlo
2013-12-30 16:15 ` Carlo
2013-12-30 19:29 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=loom.20131230T100101-18@post.gmane.org \
--to=catull@gmail.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).