completion function for apachectl

completion function for apachectl

[Fletch]

        This completes for apachectl (a utility that comes with apache 
to do things such as restarting apache, syntax checking it's
configuration file, and the like).


--- /dev/null   Tue May  5 16:32:27 1998
+++ _apachectl  Fri Feb 23 10:01:49 2001
@@ -0,0 +1,12 @@
+#compdef apachectl
+
+local curcontext="$curcontext" state line commands ret=1
+typeset -A opt_args
+
+commands=( start startssl stop restart fullstatus status 
+           graceful configtest help )
+
+_arguments \
+  ":Choose an action:($commands)" && ret=0
+
+return $ret




-- 
Fletch                | "If you find my answers frightening,       __`'/|
fletch@phydeaux.org   |  Vincent, you should cease askin'          \ o.O'
770 933-0600 x211(w)  |  scary questions." -- Jules                =(___)=
                      |                                               U

Re: completion function for apachectl

[Fletch]

>>>>> "Sven" == Sven Wischnowsky <wischnow@informatik.hu-berlin.de> writes:

    Sven> Fletch wrote:

    >> This completes for apachectl (a utility that comes with apache
    >> to do things such as restarting apache, syntax checking it's
    >> configuration file, and the like).

    Sven> Thanks for writing a new completion function.

[... Brutal savaging of my version choped :) ]


        Thanks for critiquing it.  It was rather cargo cultish and
hacked together from the bits and pieces of whatever looked similar to 
what I was trying to do.  I better go re-read that section of the
guide a couple more times.


    Sven> Hm. Since there are several commands (and scripts[1]) that
    Sven> only get one command as argument, I'm almost tempted to add
    Sven> a generic version of the above as a utility
    Sven> function. Opinions?

    Sven> Bye Sven

    Sven> [1] Wasn't there a request for init-script completion on the
    Sven> debian list?

        I've been frustrated that TAB doesn't Do What I Mean for stuff 
in /etc/rc.d/init.d several times.  You almost could generate it on
the fly with a for over /etc/rc.d/init.d/*, maybe with a style for
things that take strange arguments other than start or stop.

-- 
Fletch                | "If you find my answers frightening,       __`'/|
fletch@phydeaux.org   |  Vincent, you should cease askin'          \ o.O'
770 933-0600 x211(w)  |  scary questions." -- Jules                =(___)=
                      |                                               U

Re: completion function for apachectl

[Sven Wischnowsky]

Fletch wrote:

>         This completes for apachectl (a utility that comes with apache 
> to do things such as restarting apache, syntax checking it's
> configuration file, and the like).

Thanks for writing a new completion function.

Just some comments:

> +#compdef apachectl
> +
> +local curcontext="$curcontext" state line commands ret=1
> +typeset -A opt_args

Most of these need only be made local if `_arguments' is used with a
`->state' action.

> +commands=( start startssl stop restart fullstatus status 
> +           graceful configtest help )

Using an extra array maybe slightly more readable, but in a function
as simple as this one...

> +_arguments \
> +  ":Choose an action:($commands)" && ret=0
> +
> +return $ret

No need for `&& ret=0 ... return $ret'. Without a `return' the return
value of a function is the return value of the last command in it.

And using `_arguments' is only really useful if there is some more to
do (options, multiple arguments,...) -- otherwise it's quite
expensive.

One could get the same with the simpler:

  #compdef apachectl

  local expl

  if [[ CURRENT -eq 2 ]]; then
    _wanted commands expl command compadd \
        start startssl stop restart fullstatus status graceful configtest help
  else
    _message 'no more arguments'
  fi

Hm. Since there are several commands (and scripts[1]) that only get one
command as argument, I'm almost tempted to add a generic version of
the above as a utility function. Opinions?

Bye
 Sven

[1] Wasn't there a request for init-script completion on the debian list?

--
Sven Wischnowsky                         wischnow@informatik.hu-berlin.de