zsh-workers
 help / color / mirror / code / Atom feed
From: Greg Klanderman <gak@klanderman.net>
To: zsh-workers@sunsite.dk
Subject: PATCH: add zle-line-finish special widget
Date: Fri, 16 Jan 2009 18:54:03 -0500	[thread overview]
Message-ID: <m33afix0x0.fsf_-_@klanderman.net> (raw)
In-Reply-To: <m3k5916unp.fsf@klanderman.net> (Greg Klanderman's message of "Sun, 11 Jan 2009 23:00:10 -0500")


Hi, I'm re-submitting my previous patch having addressed some of
Bart's concerns.  In particular, I have renamed the special widget to
"zle-line-finish" (was zle-line-finished) and have added code to
save/restore errflag and retflag so that the values from the end of
zlecore() are preserved.

Bart also made the following comments on my original patch which I
have not addressed:

> it's possible that the zle-line-finish widget should not run when
> errflag != 0.

> I don't know all the ramifications of the values of various globals
> at the end of zlecore().  PWS?

Peter, could you comment?

cheers,
Greg


Index: Doc/Zsh/zle.yo
===================================================================
RCS file: /cvsroot/zsh/zsh/Doc/Zsh/zle.yo,v
retrieving revision 1.75
diff -u -r1.75 zle.yo
--- Doc/Zsh/zle.yo	9 Dec 2008 17:37:01 -0000	1.75
+++ Doc/Zsh/zle.yo	16 Jan 2009 23:36:37 -0000
@@ -870,6 +870,11 @@
 (The command inside the function sets the keymap directly; it is
 equivalent to tt(zle vi-cmd-mode).)
 )
+tindex(zle-line-finish)
+item(tt(zle-line-finish))(
+This is similar to tt(zle-line-init) but is executed every time the
+line editor has finished reading a line of input.
+)
 tindex(zle-keymap-select)
 item(tt(zle-keymap-select))(
 Executed every time the keymap changes, i.e. the special parameter
Index: Src/Zle/zle_main.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/Zle/zle_main.c,v
retrieving revision 1.121
diff -u -r1.121 zle_main.c
--- Src/Zle/zle_main.c	9 Dec 2008 17:37:01 -0000	1.121
+++ Src/Zle/zle_main.c	16 Jan 2009 23:36:37 -0000
@@ -1212,6 +1212,18 @@
 
     zlecore();
 
+    if ((initthingy = rthingy_nocreate("zle-line-finish"))) {
+	int saverrflag = errflag;
+	int savretflag = retflag;
+	char *args[2];
+	args[0] = initthingy->nam;
+	args[1] = NULL;
+	execzlefunc(initthingy, args, 1);
+	unrefthingy(initthingy);
+	errflag = saverrflag;
+	retflag = savretflag;
+    }
+
     statusline = NULL;
     invalidatelist();
     trashzle();


  parent reply	other threads:[~2009-01-16 23:54 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <18789.30656.261463.382208@gargle.gargle.HOWL>
     [not found] ` <20090110095231.GA61601@redoubt.spodhuis.org>
     [not found]   ` <m33afq97gg.fsf@klanderman.net>
     [not found]     ` <20090111025418.GA7272@redoubt.spodhuis.org>
     [not found]       ` <m3tz857mkm.fsf@klanderman.net>
     [not found]         ` <090111110748.ZM12349@torch.brasslantern.com>
     [not found]           ` <m3r63975pd.fsf@klanderman.net>
     [not found]             ` <m3ocyd70aj.fsf@klanderman.net>
     [not found]               ` <090111193317.ZM12655@torch.brasslantern.com>
2009-01-12  4:00                 ` some way to inherit kill ring in su'd shell? Greg Klanderman
2009-01-12  5:33                   ` Bart Schaefer
2009-01-12 19:33                     ` Greg Klanderman
2009-01-12 23:55                       ` Richard Hartmann
2009-01-16 23:54                   ` Greg Klanderman [this message]
2009-01-17 17:48                     ` PATCH: add zle-line-finish special widget Peter Stephenson
2009-01-17 18:08                     ` Bart Schaefer
2009-01-23  0:50                       ` Greg Klanderman
2009-01-23  9:37                         ` Peter Stephenson
2009-01-28  4:38                           ` Greg Klanderman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m33afix0x0.fsf_-_@klanderman.net \
    --to=gak@klanderman.net \
    --cc=zsh-workers@sunsite.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).