From: Greg Klanderman <gak@klanderman.net>
To: zsh-workers@sunsite.dk
Subject: Re: need help debugging cvs completion problem
Date: Sun, 28 Jun 2009 13:49:40 -0400 [thread overview]
Message-ID: <m3fxdkmeob.fsf@klanderman.net> (raw)
In-Reply-To: <20090628113802.GA3707@primenet.com.au> (Geoff Wing's message of "Sun, 28 Jun 2009 21:38:02 +1000")
>>>>> Geoff Wing <gcw@zsh.org> writes:
> It's incorrectly listed. It's really 18796 (on zsh-workers).
Thank you Geoff!
Peter,
I now see why _path_files was being used prior to your change to
_cvs_existing_entries back in 2003 - your form (with compadd, since
otherwise it doesn't do anything) does not handle completing files in
a subdirectory of the current directory, i.e.
% cvs annotate foo/bar<tab>
The directory prefix is getting removed in _cvs_existing_entries, is
it safe to just paste '$linedir' back on the front of the resulting
filenames?
Once I figure that out, I'll resume my plan to make the analogous fix
to _cvs_modified_entries. Would anyone be opposed to my starting by
using Bart's equivalent series of substitutions (in his followup to
18796) rather than the mother-of-all substitutions currently found
there? I presume we're not striving to unmaintainable obfuscation, is
there some efficiency reason for the single substitution?
thanks,
Greg
next prev parent reply other threads:[~2009-06-28 17:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-26 22:19 Greg Klanderman
2009-06-27 20:24 ` Peter Stephenson
2009-06-28 0:48 ` Greg Klanderman
2009-06-28 1:11 ` Greg Klanderman
2009-06-28 11:38 ` Geoff Wing
2009-06-28 17:49 ` Greg Klanderman [this message]
2009-06-28 18:52 ` Greg Klanderman
2009-06-28 19:54 ` Peter Stephenson
2009-06-28 20:16 ` Peter Stephenson
2009-07-07 14:15 ` Greg Klanderman
2009-07-07 15:11 ` Peter Stephenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3fxdkmeob.fsf@klanderman.net \
--to=gak@klanderman.net \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).